Changes between Version 1 and Version 2 of Ticket #14567
 Timestamp:
 05/12/13 18:02:59 (8 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #14567

Property
Status
changed from
new
toneeds_review

Property
Status
changed from

Ticket #14567 – Description
v1 v2 1 1 Continued fractions (in sage.rings.contfrac) do not do what we expect: 2 * it only deals with rational numbers3 * there is no dedicated method for numerical approximations (which is one of the first aim of continued fractions)4 * there is no bridge with words (sage.combinat.words)5 * there is no bridge with quadratic numbers (see also #11345)6 2 7 Moreover, categories are not properly initialized nor used. 3 0. categories are not properly initialized nor used. 4 1. it only deals with rational numbers 5 2. there is no dedicated method for numerical approximations (which is one of the first aim of continued fractions) 6 4. there is no bridge with quadratic numbers (see also #11345) 7 3. there is no bridge with words (sage.combinat.words) 8 8 9 The patch proposed here improves the current version by addressing the four issues above. 9 The patch proposed here develop some general design for dealing with continued fractions and solves the issues 0, 1 and 4 (and I hope 2); see the discussion below. 10 11 {{{ 12 sage: K.<sqrt2> = QuadraticField(2) 13 sage: cff = (sqrt2/3 + 1/4).continued_fraction(); cff 14 [0; 1, (2, 1, 1, 2, 3, 2, 1, 1, 2, 5, 1, 1, 14, 1, 1, 5)*] 15 sage: cff.value() 16 1/3*sqrt2 + 1/4 17 }}} 18 In particular we solve the question in #11345.