Changes between Initial Version and Version 1 of Ticket #14562


Ignore:
Timestamp:
05/10/13 13:01:25 (8 years ago)
Author:
ncohen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14562

    • Property Status changed from new to needs_review
  • Ticket #14562 – Description

    initial v1  
    11Wow.
     2
    23This patch is scary.
     4
    35Really scary.
     6
    47The construction is awful, and there's not much that I could do to make the code clear.
    5 The point is that I do not understand the construction myself, and I did not try either, I just wanted to implement it. And it already took Quiiiiiiiiiiiiiite a lot of times, and headaches `:-)`
     8
     9The point is that I do not understand the construction myself, and I did not try either, I just wanted to implement it. And it already took Quiiiiiiiiiiiiiite a lot of time, and headaches `:-)`
    610
    711This patch implements a method that returns a Steiner Quadruple System whenever it exists. It follows the construction from Haim Hanani in a paper from 1960, which gives 6 differents constructions to make a large system from a small one, and all must be used to solve all cases.
    812
    9 Considering that I was able to test this code until `n =`, and that all constructions have been tested for different values of `n`, I believe that this code is a correct counterpart of the paper itself. That's what makes me think that there is no typo in the code anymore (I fixed one thousand of them while writing it). So, even if it is very, very scary and unclear, I think that it is correct... Experimentally `:-)`
     13Considering that I was able to test this code until `n =300`, and that all constructions have been tested for different values of `n`, I believe that this code is a correct counterpart of the paper itself. That's what makes me think that there is no typo in the code anymore (I fixed one thousand of them while writing it). So, even if it is very, very scary and unclear, I think that it is correct... Experimentally `:-)`
    1014
    1115Nathann