#14561 closed enhancement (fixed)
cleanup of doc in sha_tate.py
Reported by: | chapoton | Owned by: | cremona |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.10 |
Component: | elliptic curves | Keywords: | documentation, tate shafarevich |
Cc: | Merged in: | sage-5.10.rc1 | |
Authors: | Frédéric Chapoton | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14571 | Stopgaps: |
Description (last modified by )
just a small patch to clean minor things in this file on tate-shafarevich
- one unused variable found by pyflakes
- minor details in the documentation
- raise converted into python3 syntax
Attachments (1)
Change History (12)
Changed 8 years ago by
comment:1 Changed 8 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
I do not have this problem on 5.10.beta1.
The reference is not duplicated in the file itself.
I will try with beta2 when I got it.
comment:4 Changed 8 years ago by
no problem either with 5.10.beta2. The doc builds without any warnings.
comment:5 Changed 8 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
Sorry for the confusion, stale citation pickle I think...
comment:6 Changed 8 years ago by
Well, thanks for the review !
comment:7 Changed 8 years ago by
- Dependencies set to #14571
- Milestone changed from sage-5.10 to sage-pending
comment:8 Changed 8 years ago by
Maybe I should rather remove the offending Unicode sha ?
comment:9 Changed 8 years ago by
No, its a good testcase. Eventually we should just extend the pdf doc build by all unicode code points that we need, and the patch at #14571 is a step in that direction.
comment:10 Changed 8 years ago by
- Merged in set to sage-5.10.rc1
- Milestone changed from sage-pending to sage-5.10
- Resolution set to fixed
- Status changed from positive_review to closed
comment:11 Changed 8 years ago by
Note: See
TracTickets for help on using
tickets.
You are duplicating the citation: