Opened 9 years ago

Closed 9 years ago

#14554 closed defect (fixed)

Fix typo in combinat.py

Reported by: scmancuso Owned by: sage-combinat
Priority: trivial Milestone: sage-5.10
Component: combinatorics Keywords: beginner
Cc: Merged in: sage-5.10.beta3
Authors: Scott Mancuso Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The string representation for FilteredCombinatorialClass? gives the description as "Filtered sublass of " instead of "Filtered subclass of " (note the missing 'c' in the first). This is a simple correction of this typo and all places where it occurs in doctests.

Attachments (1)

trac_14554_combinat_typo.patch (1.3 KB) - added by scmancuso 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by scmancuso

comment:1 Changed 9 years ago by scmancuso

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by scmancuso

  • Keywords beginner added

comment:3 Changed 9 years ago by nthiery

  • Reviewers set to Nicolas M. Thiéry

Sounds good. You can set a positive review on my behalf as soon as the patchbot light goes green!

Thanks for this first contribution!

By the way, don't worry too much for *CombinatorialClass?: those are meant to disappear at some point.

Cheers,

Nicolas

comment:4 Changed 9 years ago by kcrisman

  • Status changed from needs_review to positive_review

Patchbot isn't working right, but it's doable by hand.

Doctesting 1 file.
sage -t sage/combinat/combinat.py
    [397 tests, 15.17 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 15.3 seconds
    cpu time: 2.4 seconds
    cumulative wall time: 15.2 seconds

Running full tests now but I don't think there will be a problem, Nicolas.

comment:5 Changed 9 years ago by kcrisman

All is well.

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.10.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.