Opened 8 years ago

Closed 7 years ago

#14547 closed enhancement (fixed)

McLaughlin graph constructor

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.12
Component: graph theory Keywords:
Cc: rbeezer Merged in: sage-5.12.beta2
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ncohen)

Annnnnnnnnnnd I think that this is the last one I can steal from without help in maths ^^;

The tests are rather long, but they are not flagged with "long time". This is because they are already flagged with "optional gap_packages", and 1) I have no idea how flags should be stacked in such situations 2) with an "optional" flag the doctests will be almost never run, so let's not make it even rarer :-P

And. I computed some layouts for this graph, all of them looking like a giant black thing. That was in png. I also tried svg, and you can check at this address (if you can display it :-P) what we are missing by not adding the layout to Sage's constructor :


Attachments (2)

trac_14547.patch (3.2 KB) - added by ncohen 8 years ago.
trac_14547_review.patch (1.6 KB) - added by chapoton 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by ncohen

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by rbeezer

  • Cc rbeezer added

Changed 8 years ago by ncohen

comment:3 Changed 8 years ago by chapoton

looks good to me. I have made cosmetic changes (pep8) in my review patch.

If you are happy with that, you can set a positive review.

comment:4 Changed 8 years ago by ncohen

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

Excellent ! Thank you very much :-)


comment:5 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:6 Changed 7 years ago by jdemeyer

The reviewer patch needs a proper commit message.

Changed 7 years ago by chapoton

comment:7 Changed 7 years ago by chapoton

commit message added

comment:8 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.12.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.