Opened 8 years ago

Closed 8 years ago

#14534 closed enhancement (fixed)

Composition of ring homomorphisms

Reported by: tfeulner Owned by: tbd
Priority: trivial Milestone: sage-5.10
Component: performance Keywords:
Cc: Merged in: sage-5.10.beta2
Authors: Thomas Feulner Reviewers: Francis Clarke
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

When composing a RingHomomorphism and an instance of RingHomomorphism_im_gens then the images of the generators are again checked for their validity.

This patch avoids this unnecessary test.

With the patch

sage: F.<a> = GF(3^100, 'a')
sage: f= F.hom([a^(3^5)])
sage: %timeit f^100
1 loops, best of 3: 290 ms per loop

before:

1 loops, best of 3: 1.73 s per loop

Attachments (1)

trac_14534_ring_morphism_composition.patch (797 bytes) - added by tfeulner 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by tfeulner

comment:1 Changed 8 years ago by fwclarke

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by fwclarke

  • Reviewers set to Francis Clarke
  • Status changed from needs_review to positive_review

Works perfectly. Positive review.

comment:3 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.