Opened 9 years ago
Closed 9 years ago
#14531 closed defect (fixed)
Gurobi is not built anymore because of a typo !
Reported by:  Nathann Cohen  Owned by:  Nathann Cohen 

Priority:  major  Milestone:  sage5.10 
Component:  linear programming  Keywords:  
Cc:  Merged in:  sage5.10.beta2  
Authors:  Nathann Cohen  Reviewers:  Leif Leonhardy 
Report Upstream:  N/A  Work issues:  
Branch:  Commit:  
Dependencies:  Stopgaps: 
Description
Looks like the value of SAGE_INC
used to end with a '/', and that changed. As a result the Gurobi backend is not built anymore !
As reported on sagesupport : https://groups.google.com/d/msg/sagesupport/QC9lPACXIcY/55AEp2mqX7EJ
Nathann
Attachments (1)
Change History (10)
Changed 9 years ago by
Attachment:  trac_14531.patch added 

comment:1 Changed 9 years ago by
Status:  new → needs_review 

comment:2 followup: 4 Changed 9 years ago by
Component:  linear programming → linear algebra 

Reviewers:  → Leif Leonhardy 
Status:  needs_review → positive_review 
comment:3 Changed 9 years ago by
Component:  linear algebra → linear programming 

Ooops...
P.S.: Applies clean to Sage 5.10.beta1.
comment:5 Changed 9 years ago by
And the winner is:
#14393 ("Clean up module_list.py to enforce and normalize the use of SAGE_INC over" )

module_list.py
diff git a/module_list.py b/module_list.py
a b 6 6 from sage.env import * 7 7 8 8 SAGE_INC = os.path.join(SAGE_LOCAL, 'include') 9 # this is needed until someone fixes the usage of SAGE_INC in this file10 SAGE_INC += '/'11 9 12 10 ######################################################### 13 11 ### BLAS setup
:)
comment:6 Changed 9 years ago by
Well, at least gurobi was the only one missing. Of course it could only have happened to optional spkg !
Thanks for the review ! :)
Nathann
comment:7 followup: 8 Changed 9 years ago by
Well, sorry about that. I really thought I had everything.
comment:8 Changed 9 years ago by
Replying to fbissey:
Well, sorry about that. I really thought I had everything.
Never mind. Just one more indication we should test optional spkgs more regularly, e.g. when a release candidate gets out.
comment:9 Changed 9 years ago by
Merged in:  → sage5.10.beta2 

Resolution:  → fixed 
Status:  positive_review → closed 
Hahahahahaha