Opened 6 years ago

Closed 6 years ago

#14522 closed defect (fixed)

Update optional CBC spkg and fix Sage library interface to it

Reported by: ncohen Owned by: tbd
Priority: blocker Milestone: sage-5.11
Component: packages: optional Keywords:
Cc: john_perry, was, jdemeyer Merged in: sage-5.11.beta2
Authors: Nathann Cohen, William Stein Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by leif)

This ticket updates the CBC package which did not compile on my computer (and probably others too), and a one-line patch (thanks William) fixes the problem reported there : https://groups.google.com/d/msg/sage-devel/-h-jLhNdcZs/T5wLyWUnyKsJ

Nathann

Apply:

New optional spkg: http://www.steinertriples.fr/cbc-2.8.1.p0.spkg

Attachments (1)

trac_14522.patch (633 bytes) - added by ncohen 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by ncohen

comment:1 Changed 6 years ago by ncohen

  • Authors changed from Nathann Cohen to Nathann Cohen, William Stein
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by was

  • Priority changed from major to blocker
  • Status changed from needs_review to positive_review

I've been making this change manually for a while!

Also, I'm raising the priority of this to a 5.11 blocker, since an optional package -- when installed -- totally breaks starting up Sage, so a lot of people will hit this.

Plus it's a simple 1-line fix.

comment:3 Changed 6 years ago by ncohen

Thanks !

Nathann

comment:4 Changed 6 years ago by leif

  • Cc jdemeyer added
  • Description modified (diff)
  • Summary changed from Update of CBC to Update optional CBC spkg and fix Sage library interface to it
  • Type changed from enhancement to defect

Since this updates an optional spkg, and the patch to the Sage library is trivial (and shouldn't affect others), this could probably still make it into 5.10...

(Technically, the new optional spkg cannot get "merged" without also merging the patch, just because they belong to the same ticket.)

comment:5 Changed 6 years ago by jdemeyer

  • Reviewers set to William Stein

comment:6 Changed 6 years ago by schilly

spkg landed on the servers …

comment:7 Changed 6 years ago by ncohen

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaannks :-)

Nathann

comment:8 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.11.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.