Opened 9 years ago

Closed 9 years ago

#14522 closed defect (fixed)

Update optional CBC spkg and fix Sage library interface to it

Reported by: Nathann Cohen Owned by: tbd
Priority: blocker Milestone: sage-5.11
Component: packages: optional Keywords:
Cc: John Perry, William Stein, Jeroen Demeyer Merged in: sage-5.11.beta2
Authors: Nathann Cohen, William Stein Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Leif Leonhardy)

This ticket updates the CBC package which did not compile on my computer (and probably others too), and a one-line patch (thanks William) fixes the problem reported there : https://groups.google.com/d/msg/sage-devel/-h-jLhNdcZs/T5wLyWUnyKsJ

Nathann

Apply:

New optional spkg: http://www.steinertriples.fr/cbc-2.8.1.p0.spkg

Attachments (1)

trac_14522.patch (633 bytes) - added by Nathann Cohen 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Nathann Cohen

Attachment: trac_14522.patch added

comment:1 Changed 9 years ago by Nathann Cohen

Authors: Nathann CohenNathann Cohen, William Stein
Description: modified (diff)
Status: newneeds_review

comment:2 Changed 9 years ago by William Stein

Priority: majorblocker
Status: needs_reviewpositive_review

I've been making this change manually for a while!

Also, I'm raising the priority of this to a 5.11 blocker, since an optional package -- when installed -- totally breaks starting up Sage, so a lot of people will hit this.

Plus it's a simple 1-line fix.

comment:3 Changed 9 years ago by Nathann Cohen

Thanks !

Nathann

comment:4 Changed 9 years ago by Leif Leonhardy

Cc: Jeroen Demeyer added
Description: modified (diff)
Summary: Update of CBCUpdate optional CBC spkg and fix Sage library interface to it
Type: enhancementdefect

Since this updates an optional spkg, and the patch to the Sage library is trivial (and shouldn't affect others), this could probably still make it into 5.10...

(Technically, the new optional spkg cannot get "merged" without also merging the patch, just because they belong to the same ticket.)

comment:5 Changed 9 years ago by Jeroen Demeyer

Reviewers: William Stein

comment:6 Changed 9 years ago by Harald Schilly

spkg landed on the servers …

comment:7 Changed 9 years ago by Nathann Cohen

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaannks :-)

Nathann

comment:8 Changed 9 years ago by Jeroen Demeyer

Merged in: sage-5.11.beta2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.