Opened 7 years ago

Closed 5 years ago

#14515 closed enhancement (wontfix)

Constructor for triangular graphs

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: graph theory Keywords:
Cc: Merged in:
Authors: Nathann Cohen Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Attachments (1)

trac_14515.patch (2.0 KB) - added by ncohen 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by ncohen

  • Status changed from new to needs_review

comment:2 follow-up: Changed 7 years ago by Stefan

  • Status changed from needs_review to needs_work

Looking at the patch, there seems to be a comma in the import statement rather than a dot. Also, is this an important enough class to warrant its own entry in the catalog? It's really easy to construct for end users anyway.

comment:3 in reply to: ↑ 2 Changed 7 years ago by ncohen

  • Status changed from needs_work to needs_review

Yoooooooooooooooooooooooo !!!

Looking at the patch, there seems to be a comma in the import statement rather than a dot.

Really ? How could it work then ? O_o

Fixed, anyway !

Also, is this an important enough class to warrant its own entry in the catalog? It's really easy to construct for end users anyway.

Yeah, I wondered too. Three lines and no added values, as I cannot even give a general nice embedding... Well, this thing is also meant to be a database of graphs, actually, so the more the better. At some point I would also want to be able to test a conjecture on "all graphs that Sage knows how to build".

Well, it's up to you, I am not very convinced either. Actually, I was trying to create all the strongly regular graphs I could build from Brouwer's website and get them in Sage, but after writing this class I hit a wall trying to build another weird strongly regular graph, so I sent the patch.

It's up to you then. Otherwise we can close the ticket and the code will stay here until we chose to integrate it if we want. I do not really mind.

Have fuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuun !

Nathann

Changed 7 years ago by ncohen

comment:4 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 5 years ago by Stefan

Well, given that nobody commented on this for 14 months, and the class is still trivial to construct, I propose to close the ticket and not add TriangularGraphs? to Sage.

I don't know what status change is appropriate for this, so I'm leaving it as "needs_review" for now.

Last edited 5 years ago by Stefan (previous) (diff)

comment:8 Changed 5 years ago by ncohen

  • Milestone changed from sage-6.3 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.