Opened 8 years ago

Closed 8 years ago

#14503 closed defect (fixed)

Typos in the reference manual: GAP interface and Weyl group

Reported by: mathzeta2 Owned by: mvngu
Priority: trivial Milestone: sage-5.10
Component: documentation Keywords:
Cc: Merged in: sage-5.10.beta2
Authors: Tomer Bauer Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by ncohen)

Following https://groups.google.com/forum/?fromgroups=#!topic/sage-devel/zijERXXw43M, here are two small and trivial fixes for the reference manual:

  • GAP interface misses the G in GAP.
  • Weyl group category links to a Wikipedia article that does not exist

Apply:

Attachments (2)

trac_14503_typos.patch (1.1 KB) - added by mathzeta2 8 years ago.
trac_14503_typos_wikipedia.patch (1.1 KB) - added by mathzeta2 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by mathzeta2

comment:1 follow-up: Changed 8 years ago by ncohen

Makes sense, and it is not likely to do anything very bad :-D

This being said, could you replace the line containing the link with the following ?

See the `Wikipedia page of Weyl Groups <Weyl_group>`.

That's how we now refer to Wikipedia pages :-)

Thanks !

Nathann

comment:2 Changed 8 years ago by ncohen

  • Status changed from new to needs_review

Changed 8 years ago by mathzeta2

comment:3 in reply to: ↑ 1 ; follow-up: Changed 8 years ago by mathzeta2

Replying to ncohen:

This being said, could you replace the line containing the link with the following ?

See the `Wikipedia page of Weyl Groups <Weyl_group>`.

That's how we now refer to Wikipedia pages :-)

Attached is an extra patch with proper Wikipedia links. In the process of learning Sage's ReST rules, I stumbled upon another broken Wikipedia link: multicommodity flow. I hope that piggybacking this ticket is OK.

Last edited 8 years ago by mathzeta2 (previous) (diff)

comment:4 in reply to: ↑ 3 Changed 8 years ago by ncohen

  • Description modified (diff)

Helloooooooooooooo !!

Attached is an extra patch with proper Wikipedia links. In the process of learning Sage's ReST rules, I stumbled upon another broken Wikipedia link: multicommodity flow. I hope that piggybacking this ticket is OK.

Gloops. The one from generic_graph.py is probably one of my mistakes :-)

Thank you for those patches ! There is no problem at all with having several patches on the same ticket. You just need to explicitly say in the ticket's description how they are to be applied in that case (just one, or the other, or both). I just did it, so that you can see how you can create links toward patches in a ticket :-)

comment:5 Changed 8 years ago by ncohen

  • Status changed from needs_review to positive_review

Good to go !

Nathann

comment:6 Changed 8 years ago by jdemeyer

Please fill in your real names as Author and Reviewer.

comment:7 Changed 8 years ago by ncohen

  • Reviewers set to Nathann Cohen

comment:8 Changed 8 years ago by mathzeta2

  • Authors set to Tomer Bauer

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.