Opened 6 years ago

Closed 6 years ago

#14497 closed defect (fixed)

Universal cyclotomic field fails to convert 0 to QQ

Reported by: mraum Owned by: davidloeffler
Priority: major Milestone: sage-5.10
Component: number fields Keywords: UCF
Cc: stumpc5, mraum Merged in: sage-5.10.beta2
Authors: Christian Stump Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by stumpc5)

The case of 0 was missed in _rational_.

Apply only: trac_14497-zero_conversion-cs.patch

Attachments (2)

14497-universal_cyclotomic_field_rational_zero.patch (901 bytes) - added by mraum 6 years ago.
trac_14497-zero_conversion-cs.patch (1.9 KB) - added by stumpc5 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by vbraun

Please no catch-all except: blocks (think KeyboardInterrupt). How about a doctest to make sure that it stays fixed?

comment:2 Changed 6 years ago by mraum

This is not meant to be an actual patch, but it's my preliminary fix that I use for other computations. I plan to prepare a real patch in Summer during Sage Days in Leiden.

Anyway.Thanks for having a look at this so quickly.

comment:3 Changed 6 years ago by stumpc5

  • Authors set to Christian Stump
  • Description modified (diff)
  • Keywords UCF added
  • Status changed from new to needs_review

comment:4 follow-up: Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 6 years ago by stumpc5

  • Status changed from positive_review to needs_work

Replying to vbraun:

Looks good to me.

I just saw that I have the same bug in __pow__ and will add the fix to this patch as well.

Changed 6 years ago by stumpc5

comment:6 in reply to: ↑ 5 Changed 6 years ago by stumpc5

  • Status changed from needs_work to positive_review

Replying to stumpc5:

Replying to vbraun:

Looks good to me.

I just saw that I have the same bug in __pow__ and will add the fix to this patch as well.

done - though I am not very certain what the Sage convention is to define 0^0.

comment:7 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.10.beta2

comment:8 Changed 6 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.