Opened 9 years ago

Closed 9 years ago

#14487 closed defect (fixed)

lrcalc spkg contains broken symlinks

Reported by: jdemeyer Owned by: jdemeyer
Priority: critical Milestone: sage-5.10
Component: packages: standard Keywords:
Cc: nthiery, jpflori, asbuch Merged in: sage-5.10.beta3
Authors: Jeroen Demeyer Reviewers: Nicolas M. Thiéry
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

In the lrcalc package: 

jdemeyer@boxen:~/spkg/lrcalc-1.1.6$ ls -l src/m4
total 0
lrwxrwxrwx 1 jdemeyer jdemeyer 29 Apr 25 11:46 libtool.m4 -> /usr/share/aclocal/libtool.m4
lrwxrwxrwx 1 jdemeyer jdemeyer 31 Apr 25 11:46 ltoptions.m4 -> /usr/share/aclocal/ltoptions.m4
lrwxrwxrwx 1 jdemeyer jdemeyer 29 Apr 25 11:46 ltsugar.m4 -> /usr/share/aclocal/ltsugar.m4
lrwxrwxrwx 1 jdemeyer jdemeyer 31 Apr 25 11:46 ltversion.m4 -> /usr/share/aclocal/ltversion.m4
lrwxrwxrwx 1 jdemeyer jdemeyer 33 Apr 25 11:46 lt~obsolete.m4 -> /usr/share/aclocal/lt~obsolete.m4

These are broken symbolic links and should be replaced by the actual files (or removed altogether).

spkg: ​http://boxen.math.washington.edu/home/jdemeyer/spkg/lrcalc-1.1.6.p0.spkg (spkg diff​)

Attachments (1)

lrcalc-1.1.6.p0.diff​ (4.1 KB) - added by jdemeyer 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by jdemeyer

  • Cc jpflori added

comment:2 Changed 9 years ago by vbraun

Protip: Use make dist to generate a tarball from sources. Do not just copy stuff from the repo into the spkg.

comment:3 Changed 9 years ago by jdemeyer

  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

Reported upstream by email.

comment:4 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 9 years ago by jdemeyer

I have no answer from upstream yet... perhaps I should just release lrcalc-1.1.6.p0 with fixed sources?

Last edited 9 years ago by jdemeyer (previous) (diff)

Changed 9 years ago by jdemeyer

comment:6 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Priority changed from minor to critical
  • Status changed from new to needs_review

Critical because these broken symlinks break certain scripts. Please review.

comment:7 Changed 9 years ago by nthiery

  • Cc asbuch added
  • Status changed from needs_review to positive_review

I just had a look at the diff and it looks good. I also installed the package and ran the tests (of the spkg and in sage/libs/lrcalc).

In the long run it will be best when upstream (Anders!) fixes the aforementionned issues, but that does the job in the mean time!

Thanks Jeroen!

comment:8 Changed 9 years ago by jdemeyer

  • Reviewers set to Nicolas M. Thiéry

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.10.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.