Opened 10 years ago
Closed 10 years ago
#14478 closed enhancement (fixed)
(Ring-) Learning with Errors Oracles
Reported by: | malb | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-5.10 |
Component: | cryptography | Keywords: | |
Cc: | Merged in: | sage-5.10.beta3 | |
Authors: | Martin Albrecht, Robert Fitzpatrick, Daniel Cabracas, Florian Göpfert, Michael Schneider | Reviewers: | Minh Van Nguyen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The (Ring-)LWE problem is a central problem in cryptography these days, but generators for LWE instances are not easily available. At
a family of LWE generators is implemented.
We should include this in Sage.
Attachments (3)
Change History (15)
comment:1 Changed 10 years ago by
Status: | new → needs_review |
---|
comment:2 Changed 10 years ago by
comment:4 Changed 10 years ago by
I've updated the patch
- adding the module to the reference manual
- fixed cosmetic issues in the HTML output
- fixed bug where
m
wasn't restricted where it should
See commits
- https://bitbucket.org/malb/lwe-generator/commits/8aaa2b6f0b8eeda5e4254087c93aa208f1471856
- https://bitbucket.org/malb/lwe-generator/commits/a7ae2a422e3af0857fe5b225393b46d09230d40a
for diff to previous patch.
Changed 10 years ago by
Attachment: | trac_14478_lwe.patch added |
---|
Changed 10 years ago by
Attachment: | trac_14478_reviewer.patch added |
---|
comment:7 Changed 10 years ago by
Reviewers: | → Minh Van Nguyen |
---|
comment:8 Changed 10 years ago by
Status: | needs_review → positive_review |
---|
Reviewer patch looks fine, thanks Minh!
comment:9 Changed 10 years ago by
Status: | positive_review → needs_work |
---|
dochtml.log:[cryptogra] /mazur/release/merger/sage-5.10.beta3/local/lib/python2.7/site-packages/sage/crypto/lwe.py:docstring of sage.crypto.lwe:4: WARNING: Bullet list ends without a blank line; unexpected unindent.
Changed 10 years ago by
Attachment: | trac_14478_fix-indent.patch added |
---|
comment:10 Changed 10 years ago by
Status: | needs_work → needs_review |
---|
The indentation should be fixed now.
comment:11 Changed 10 years ago by
Status: | needs_review → positive_review |
---|
I rebuilt the docs with the three patches applied and saw no warning.
comment:12 Changed 10 years ago by
Merged in: | → sage-5.10.beta3 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Note to reviewer: we cross-refereed the correctness of parameter choices, so the main task would probably be to check that the patch is up to Sage's formal standards.