Opened 7 years ago

Closed 7 years ago

#14478 closed enhancement (fixed)

(Ring-) Learning with Errors Oracles

Reported by: malb Owned by: mvngu
Priority: major Milestone: sage-5.10
Component: cryptography Keywords:
Cc: Merged in: sage-5.10.beta3
Authors: Martin Albrecht, Robert Fitzpatrick, Daniel Cabracas, Florian Göpfert, Michael Schneider Reviewers: Minh Van Nguyen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The (Ring-)LWE problem is a central problem in cryptography these days, but generators for LWE instances are not easily available. At

https://bitbucket.org/malb/lwe-generator/

a family of LWE generators is implemented.

We should include this in Sage.

Attachments (3)

trac_14478_lwe.patch (37.6 KB) - added by malb 7 years ago.
trac_14478_reviewer.patch (4.9 KB) - added by mvngu 7 years ago.
trac_14478_fix-indent.patch (698 bytes) - added by mvngu 7 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 7 years ago by malb

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by malb

Note to reviewer: we cross-refereed the correctness of parameter choices, so the main task would probably be to check that the patch is up to Sage's formal standards.

comment:3 Changed 7 years ago by Bouillaguet

Hi Martin & friends, I'm on it. Give me a day or so.

comment:4 Changed 7 years ago by malb

I've updated the patch

  • adding the module to the reference manual
  • fixed cosmetic issues in the HTML output
  • fixed bug where m wasn't restricted where it should

See commits

for diff to previous patch.

Changed 7 years ago by malb

comment:5 Changed 7 years ago by malb

fixed doctest failure.

Changed 7 years ago by mvngu

comment:6 Changed 7 years ago by mvngu

It looks OK. The reviewer patch fixes some typos.

comment:7 Changed 7 years ago by mvngu

  • Reviewers set to Minh Van Nguyen

comment:8 Changed 7 years ago by malb

  • Status changed from needs_review to positive_review

Reviewer patch looks fine, thanks Minh!

comment:9 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_work
dochtml.log:[cryptogra] /mazur/release/merger/sage-5.10.beta3/local/lib/python2.7/site-packages/sage/crypto/lwe.py:docstring of sage.crypto.lwe:4: WARNING: Bullet list ends without a blank line; unexpected unindent.

Changed 7 years ago by mvngu

comment:10 Changed 7 years ago by mvngu

  • Status changed from needs_work to needs_review

The indentation should be fixed now.

comment:11 Changed 7 years ago by malb

  • Status changed from needs_review to positive_review

I rebuilt the docs with the three patches applied and saw no warning.

comment:12 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.10.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.