Changes between Version 27 and Version 33 of Ticket #14471


Ignore:
Timestamp:
06/27/13 12:52:42 (8 years ago)
Author:
SimonKing
Comment:

I think it would be a good idea to show that the hash actually did change. I extended the new test accordingly, in a review patch.

Positive review, then!

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14471

    • Property Status changed from needs_review to positive_review
    • Property Reviewers changed from to Simon King
  • Ticket #14471 – Description

    v27 v33  
    33One such instance is that, under some circumstances, a !WeakValueDictionary remove callback is being called but cannot find the object in the dictionary since the hash changed.
    44
    5 Apply [attachment:trac_14471_dynamic_class_hash.patch]
     5__Apply__
     6
     7- [attachment:trac_14471_dynamic_class_hash.patch]
     8- [attachment:trac_14471-review.patch]