Opened 8 years ago

Closed 8 years ago

#14464 closed enhancement (fixed)

cleanup of yang baxter graph

Reported by: chapoton Owned by: sage-combinat
Priority: minor Milestone: sage-5.10
Component: combinatorics Keywords: documentation
Cc: saliola Merged in: sage-5.10.beta1
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14299 Stopgaps:

Description (last modified by chapoton)

small patch to clean up the file sage/combinat/yang_baxter_graph.py

  • removes one unused variable (found by pyflakes)
  • cleans the doc
  • removes the 3-years old deprecation of copy
  • adds a line to the index.rst of combinat

Attachments (1)

trac-14464-cleanup_of_yang-baxter-fc.patch​ (21.1 KB) - added by chapoton 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by chapoton

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by chapoton

  • Cc saliola added
  • Description modified (diff)
  • Keywords documentation added

comment:3 Changed 8 years ago by tscrim

  • Dependencies set to #14299
  • Reviewers set to Travis Scrimshaw

Hey Frederic,

Looks good. Just one trivial conflict with #14299. Could you rebase it? Once done, you can upload the patch and set a positive review on my behalf.

Thanks,
Travis

Changed 8 years ago by chapoton

comment:4 Changed 8 years ago by chapoton

  • Status changed from needs_review to positive_review

Here is a rebased patch. Positive review, then. Thanks Travis !

comment:5 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.