Opened 10 years ago

Closed 10 years ago

#14462 closed enhancement (fixed)

Faster implementation for number of standard skew tableaux

Reported by: mhansen Owned by: sage-combinat
Priority: minor Milestone: sage-5.10
Component: combinatorics Keywords:
Cc: tscrim Merged in: sage-5.10.beta0
Authors: Mike Hansen Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Attachments (1)

trac_14462.patch (1.8 KB) - added by mhansen 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by mhansen

Status: newneeds_review

comment:2 Changed 10 years ago by mhansen

Description: modified (diff)

comment:3 Changed 10 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Looks good Mike.

Thanks,
Travis

Some timings with the patch:

sage: %timeit StandardSkewTableaux([[8,3,2,1], [1,1]]).cardinality()
1000 loops, best of 3: 797 us per loop

Before:

sage: %timeit StandardSkewTableaux([[8,3,2,1], [1,1]]).cardinality()
1 loops, best of 3: 1.73 s per loop

comment:4 Changed 10 years ago by jdemeyer

Status: positive_reviewneeds_work

The patch needs a proper commit message.

Changed 10 years ago by mhansen

Attachment: trac_14462.patch added

comment:5 Changed 10 years ago by mhansen

Status: needs_workpositive_review

Done.

comment:6 Changed 10 years ago by jdemeyer

Merged in: sage-5.10.beta0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.