Opened 10 years ago

Closed 10 years ago

#14453 closed defect (fixed)

libGAP error handling bug

Reported by: Jeroen Demeyer Owned by: William Stein
Priority: minor Milestone: sage-5.10
Component: interfaces Keywords:
Cc: Volker Braun Merged in: sage-5.10.beta0
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

The libGAP error handler (error_handler()) in sage/libs/gap/util.pyx should use set_sage_signal_handler_message() instead of sig_str(). Unfortunately, this exposes a bug in GCC-4.8.0: #14460 (work-around: compile with -fno-tree-dominator-opts).

Attachments (2)

sage_crash_ihsJs4.log (53.8 KB) - added by Jeroen Demeyer 10 years ago.
14453_libgap.patch (3.7 KB) - added by Jeroen Demeyer 10 years ago.

Download all attachments as: .zip

Change History (16)

Changed 10 years ago by Jeroen Demeyer

Attachment: sage_crash_ihsJs4.log added

comment:1 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

comment:2 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 Changed 10 years ago by Jeroen Demeyer

Looks like a GCC compiler bug (GCC-4.8.0).

comment:4 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

comment:5 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

comment:6 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

comment:7 Changed 10 years ago by Volker Braun

Thanks for debugging this! Should we still treat this as critical or maybe just wait until gcc-4.8.1 is out?

comment:8 Changed 10 years ago by Jeroen Demeyer

Independently of the GCC issue, there still is a segmentation fault with Cython-0.19b2. Perhaps we should also fix that here.

comment:9 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

comment:10 Changed 10 years ago by Jeroen Demeyer

The Cython segfault also looks like an upstream (Cython-0.19b2) problem. So libGAP does a good job of testing various upstream projects :-)

comment:11 Changed 10 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Description: modified (diff)
Status: newneeds_review

Modulo upstream issues, this patch should be fine and can be applied.

Changed 10 years ago by Jeroen Demeyer

Attachment: 14453_libgap.patch added

comment:12 Changed 10 years ago by Jeroen Demeyer

Priority: criticalminor

The critical bug is #14460.

comment:13 Changed 10 years ago by Volker Braun

Reviewers: Volker Braun
Status: needs_reviewpositive_review

Looks good to me.

comment:14 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.10.beta0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.