Changes between Version 1 and Version 6 of Ticket #14448


Ignore:
Timestamp:
04/15/13 15:37:10 (8 years ago)
Author:
tscrim
Comment:

Looks good to me.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14448

    • Property Status changed from new to positive_review
    • Property Authors changed from to Thierry Monteil
    • Property Cc zimmerma added
    • Property Reviewers changed from to Travis Scrimshaw
  • Ticket #14448 – Description

    v1 v6  
    66
    77By the way, the variable name '`mantissa`' sometimes (always?) appears in the source with the meaning of a signed mantissa. I would suggest to renamed it `signed_mantissa` or `s_mantissa` to ease code reading (though i do not feel able to detect which one is signed or not along the code). See for example the `.exact_rational()` method in `real_mpfr.pyx`.
     8
     9----
     10
     11Apply: [attachment:trac_14448_sign_of_mantissa-tm.2.patch]