Changes between Version 1 and Version 2 of Ticket #14447


Ignore:
Timestamp:
04/12/13 12:30:15 (8 years ago)
Author:
jpflori
Comment:

Ok, I've put up four different patches which should achieve the same goal :

  • the uname, echo and sed version make minimal changes by modifying UNAME on Cygwin only using the corresponding command to detect we are on Cygwin (uname was suggested by Jeroen on #14406, echo avoid recalling uname, sed is what is used in sage/bin/sage-env to modify UNAME on Cygwin)
  • the case version does not modify UNAME but replace the if/elif/elif/.../else construction used to filter OSes by a case statement.

This last one is my preferred one, but I'll let Jeroen decide.

I tested it on Linux, Cygwin and Solaris this time, so the patches should be fine.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14447

    • Property Status changed from new to needs_review
  • Ticket #14447 – Description

    v1 v2  
    11The prereqs were not sufficiently modified in #14406 to build Sage on Cygwin without setting SAGE_PORT.
    22
    3 Apply [attachment:trac_14447-cygwin.patch].
     3Apply [attachment:trac_14447-case.patch].