Opened 8 years ago
Last modified 4 years ago
#14444 needs_work enhancement
Implement Quiver mutation types for GaleRobinson Quivers and other Period quivers
Reported by:  gmoose05  Owned by:  sagecombinat 

Priority:  major  Milestone:  sage6.10 
Component:  combinatorics  Keywords:  quiver 
Cc:  stumpc5  Merged in:  
Authors:  Gregg Musiker  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/chapoton/14444 (Commits, GitHub, GitLab)  Commit:  cc6b97f10c09be4ff44b4de42794120da7c0f52a 
Dependencies:  Stopgaps: 
Description (last modified by )
See Fordy and Marsh's paper http://arxiv.org/abs/0904.0200, in particular Example 8.7.
Apply:
Attachments (3)
Change History (30)
comment:1 Changed 8 years ago by
Changed 8 years ago by
Changed 8 years ago by
comment:2 Changed 8 years ago by
 Description modified (diff)
 Status changed from new to needs_review
This patch has now been updated and works directly with digraphs as opposed to matrices.
It also automatically reinterprets the primitive period 1 quivers as the associated affine A quivers.
A future ticket or patch will possible include general period 1 quivers or other quivers from Brane Tilings.
Should be ready for review now.
Gregg
comment:3 Changed 8 years ago by
 Description modified (diff)
It was not necessary to replace the duplicate/unused patch by an empty patch. You can give instructions for the bot in comments, as follows:
apply trac_14444PeriodQuivers.patch
then the bot will only apply this patch.
One remark:
For links to arxiv, you should use the arxiv role, like for example :arxiv:`0904.0200`
comment:4 Changed 8 years ago by
 Milestone changed from sage5.11 to sage5.12
comment:6 Changed 8 years ago by
comment:7 Changed 8 years ago by
 Keywords quiver added; quivers removed
Changed 8 years ago by
comment:8 Changed 8 years ago by
 Status changed from needs_review to needs_work
comment:9 Changed 8 years ago by
Examples need to be slightly updated so that Period 1 Primitives recongized as Affine A when QuiverMutationType?(['P1',n,k]) is called.
Also, would be good for interface to input classes for other period 1 quivers in this patch rather than a future patch.
comment:10 Changed 7 years ago by
 Branch set to u/chapoton/14444
 Commit set to da7a70034655aa7d6f12ef6505f9e39e3d2dd19a
comment:11 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:12 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:13 Changed 7 years ago by
 Commit changed from da7a70034655aa7d6f12ef6505f9e39e3d2dd19a to 59d3bd617cf07d2e16011e1014b87acbb8517c6d
comment:14 Changed 7 years ago by
 Commit changed from 59d3bd617cf07d2e16011e1014b87acbb8517c6d to d1dc38f95b319ab20b7e1d5dc6327e71576f2e02
comment:15 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:16 Changed 7 years ago by
 Commit changed from d1dc38f95b319ab20b7e1d5dc6327e71576f2e02 to 6c2ff95f5d6bd231181881f09fb192983504baed
comment:17 Changed 6 years ago by
 Commit changed from 6c2ff95f5d6bd231181881f09fb192983504baed to 7a6e222d8c8679dd718c524d29ec256a9ea3ab28
Branch pushed to git repo; I updated commit sha1. New commits:
7a6e222  Merge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 6.5.b4

comment:18 followup: ↓ 19 Changed 6 years ago by
Gregg, would you agree to try to get that into sage, keeping further changes for another ticket ?
comment:19 in reply to: ↑ 18 Changed 6 years ago by
Replying to chapoton:
Gregg, would you agree to try to get that into sage, keeping further changes for another ticket ?
Frederic, I am still interested in getting this into sage. I have a SAGE research assistant this semester who should have time to do this if I don't have a chance to get to this first. What did you mean exactly by "further changes"? Are you recommending I open a new ticket regarding implementing these quivers?
comment:20 Changed 6 years ago by
Well, there is already something about GaleRobinson here.
And I have also made (somewhat abusing the ticket's goal) a lot of disturbing typographical/cleanup changes in the rest of the code. It would be better to get rid of that by quick inclusion in sage, so that one can start again and have cleaner tickets. Anyway, there is a risk of conflict with the other ticket about cluster for triangulated surfaces.
comment:21 Changed 6 years ago by
I think if we want to fast track this into sage, it should be updated (if needed) to make sure that a single primitive period 1 quiver is not a new quiver mutation class but is recgonized as an affine type A quiver (or multiple copies of one). Potentially only the doctests need to be updated.
If I had more time, I would develop new quiver mutation classes for more complicated period 1 quives by adding/subtracting primitive period 1 quivers appropriately. The GaleRobinson case is essentially the case of this with two such period 1 primitives (plus the necessary fudge factor). Or by allowing the user to input a palindromic integer vector and build the rest of the period 1 quiver from the first row of the exchange matrix.
As far as you know, do these two patches still work in the current sage? If so, we can change this from needs work to needs review.
I could open up a separate ticket for the period 1 functionalities.
Gregg
comment:22 Changed 6 years ago by
 Commit changed from 7a6e222d8c8679dd718c524d29ec256a9ea3ab28 to 5de6bd52d4831b2819b9d0f3ee1b127f1347137e
Branch pushed to git repo; I updated commit sha1. New commits:
5de6bd5  Merge branch 'u/chapoton/14444' into 6.9.rc3

comment:23 Changed 6 years ago by
 Milestone changed from sage6.4 to sage6.10
comment:24 Changed 5 years ago by
 Commit changed from 5de6bd52d4831b2819b9d0f3ee1b127f1347137e to c364003c885150253d5abe6c2906e283444a6dbb
Branch pushed to git repo; I updated commit sha1. New commits:
c364003  Merge branch 'u/chapoton/14444' into 6.10.b4

comment:25 Changed 5 years ago by
 Commit changed from c364003c885150253d5abe6c2906e283444a6dbb to d89f4a4673eec9e88fab1d3794689be5459169ee
Branch pushed to git repo; I updated commit sha1. New commits:
d89f4a4  Merge branch 'u/chapoton/14444' into 7.3.b3

comment:26 Changed 5 years ago by
 Commit changed from d89f4a4673eec9e88fab1d3794689be5459169ee to 18651be9f1bd69e38e6ae641a5486e525efffcec
Branch pushed to git repo; I updated commit sha1. New commits:
18651be  Merge branch 'u/chapoton/14444' in 7.4.b2

comment:27 Changed 4 years ago by
 Commit changed from 18651be9f1bd69e38e6ae641a5486e525efffcec to cc6b97f10c09be4ff44b4de42794120da7c0f52a
Branch pushed to git repo; I updated commit sha1. New commits:
cc6b97f  Merge branch 'u/chapoton/14444' in 8.0.b9

First draft of this patch. Still needs to be better documented and streamlined. For instance, currently, creating primitive period 1 quivers by going through matrices instead of directly through digraph. But, the examples appear to work. Although sign convention should be doublechecked.
Should other types such as quivers associated to other Brane Tilings, like dP3, F0, etc. also be hardcoded?
An update to this patch will come in the next few days, but should be working for now.
Gregg