Opened 8 years ago

Last modified 4 years ago

#14444 needs_work enhancement

Implement Quiver mutation types for Gale-Robinson Quivers and other Period quivers

Reported by: gmoose05 Owned by: sage-combinat
Priority: major Milestone: sage-6.10
Component: combinatorics Keywords: quiver
Cc: stumpc5 Merged in:
Authors: Gregg Musiker Reviewers:
Report Upstream: N/A Work issues:
Branch: u/chapoton/14444 (Commits, GitHub, GitLab) Commit: cc6b97f10c09be4ff44b4de42794120da7c0f52a
Dependencies: Stopgaps:

Status badges

Attachments (3)

trac_14444-Period-Quivers.patch (10.5 KB) - added by gmoose05 8 years ago.
trac_14444-period-quivers-gm.patch (5 bytes) - added by gmoose05 8 years ago.
trac_14444_review1.patch (5.1 KB) - added by chapoton 8 years ago.

Download all attachments as: .zip

Change History (30)

comment:1 Changed 8 years ago by gmoose05

First draft of this patch. Still needs to be better documented and streamlined. For instance, currently, creating primitive period 1 quivers by going through matrices instead of directly through digraph. But, the examples appear to work. Although sign convention should be double-checked.

Should other types such as quivers associated to other Brane Tilings, like dP3, F0, etc. also be hard-coded?

An update to this patch will come in the next few days, but should be working for now.

Gregg

Last edited 8 years ago by gmoose05 (previous) (diff)

Changed 8 years ago by gmoose05

Changed 8 years ago by gmoose05

comment:2 Changed 8 years ago by gmoose05

  • Description modified (diff)
  • Status changed from new to needs_review

This patch has now been updated and works directly with digraphs as opposed to matrices.

It also automatically re-interprets the primitive period 1 quivers as the associated affine A quivers.

A future ticket or patch will possible include general period 1 quivers or other quivers from Brane Tilings.

Should be ready for review now.

Gregg

comment:3 Changed 8 years ago by chapoton

  • Description modified (diff)

It was not necessary to replace the duplicate/unused patch by an empty patch. You can give instructions for the bot in comments, as follows:

apply trac_14444-Period-Quivers.patch

then the bot will only apply this patch.

One remark:

For links to arxiv, you should use the arxiv role, like for example :arxiv:`0904.0200`

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 8 years ago by chapoton

  • Description modified (diff)

here is a first review patch

comment:6 Changed 8 years ago by chapoton

  • Authors set to Gregg Musiker

comment:7 Changed 8 years ago by chapoton

  • Keywords quiver added; quivers removed

Changed 8 years ago by chapoton

comment:8 Changed 8 years ago by gmoose05

  • Status changed from needs_review to needs_work

comment:9 Changed 8 years ago by gmoose05

Examples need to be slightly updated so that Period 1 Primitives recongized as Affine A when QuiverMutationType?(['P1',n,k]) is called.

Also, would be good for interface to input classes for other period 1 quivers in this patch rather than a future patch.

comment:10 Changed 7 years ago by chapoton

  • Branch set to u/chapoton/14444
  • Commit set to da7a70034655aa7d6f12ef6505f9e39e3d2dd19a

I have made a git branch.


New commits:

741ecfbAdded primitive period 1 quivers and Gale-Robinson quivers
da7a700trac #14444 review patch, minor details

comment:11 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:12 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:13 Changed 7 years ago by git

  • Commit changed from da7a70034655aa7d6f12ef6505f9e39e3d2dd19a to 59d3bd617cf07d2e16011e1014b87acbb8517c6d

Branch pushed to git repo; I updated commit sha1. New commits:

da36f73Merge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 14444
59d3bd6trac #14444 cosmetic clean-up

comment:14 Changed 7 years ago by git

  • Commit changed from 59d3bd617cf07d2e16011e1014b87acbb8517c6d to d1dc38f95b319ab20b7e1d5dc6327e71576f2e02

Branch pushed to git repo; I updated commit sha1. New commits:

680184fMerge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 14444
d1dc38ftrac #14444 repairing the broken doctests (sorry)

comment:15 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:16 Changed 7 years ago by git

  • Commit changed from d1dc38f95b319ab20b7e1d5dc6327e71576f2e02 to 6c2ff95f5d6bd231181881f09fb192983504baed

Branch pushed to git repo; I updated commit sha1. New commits:

b71954bMerge branch 'u/chapoton/14444' into 6.4.rc1
6c2ff95trac #14444 minor corrections

comment:17 Changed 6 years ago by git

  • Commit changed from 6c2ff95f5d6bd231181881f09fb192983504baed to 7a6e222d8c8679dd718c524d29ec256a9ea3ab28

Branch pushed to git repo; I updated commit sha1. New commits:

7a6e222Merge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 6.5.b4

comment:18 follow-up: Changed 6 years ago by chapoton

Gregg, would you agree to try to get that into sage, keeping further changes for another ticket ?

comment:19 in reply to: ↑ 18 Changed 6 years ago by gmoose05

Replying to chapoton:

Gregg, would you agree to try to get that into sage, keeping further changes for another ticket ?

Frederic, I am still interested in getting this into sage. I have a SAGE research assistant this semester who should have time to do this if I don't have a chance to get to this first. What did you mean exactly by "further changes"? Are you recommending I open a new ticket regarding implementing these quivers?

comment:20 Changed 6 years ago by chapoton

Well, there is already something about Gale-Robinson here.

And I have also made (somewhat abusing the ticket's goal) a lot of disturbing typographical/cleanup changes in the rest of the code. It would be better to get rid of that by quick inclusion in sage, so that one can start again and have cleaner tickets. Anyway, there is a risk of conflict with the other ticket about cluster for triangulated surfaces.

comment:21 Changed 6 years ago by gmoose05

I think if we want to fast track this into sage, it should be updated (if needed) to make sure that a single primitive period 1 quiver is not a new quiver mutation class but is recgonized as an affine type A quiver (or multiple copies of one). Potentially only the doctests need to be updated.

If I had more time, I would develop new quiver mutation classes for more complicated period 1 quives by adding/subtracting primitive period 1 quivers appropriately. The Gale-Robinson case is essentially the case of this with two such period 1 primitives (plus the necessary fudge factor). Or by allowing the user to input a palindromic integer vector and build the rest of the period 1 quiver from the first row of the exchange matrix.

As far as you know, do these two patches still work in the current sage? If so, we can change this from needs work to needs review.

I could open up a separate ticket for the period 1 functionalities.

Gregg

comment:22 Changed 6 years ago by git

  • Commit changed from 7a6e222d8c8679dd718c524d29ec256a9ea3ab28 to 5de6bd52d4831b2819b9d0f3ee1b127f1347137e

Branch pushed to git repo; I updated commit sha1. New commits:

5de6bd5Merge branch 'u/chapoton/14444' into 6.9.rc3

comment:23 Changed 6 years ago by chapoton

  • Milestone changed from sage-6.4 to sage-6.10

comment:24 Changed 5 years ago by git

  • Commit changed from 5de6bd52d4831b2819b9d0f3ee1b127f1347137e to c364003c885150253d5abe6c2906e283444a6dbb

Branch pushed to git repo; I updated commit sha1. New commits:

c364003Merge branch 'u/chapoton/14444' into 6.10.b4

comment:25 Changed 5 years ago by git

  • Commit changed from c364003c885150253d5abe6c2906e283444a6dbb to d89f4a4673eec9e88fab1d3794689be5459169ee

Branch pushed to git repo; I updated commit sha1. New commits:

d89f4a4Merge branch 'u/chapoton/14444' into 7.3.b3

comment:26 Changed 5 years ago by git

  • Commit changed from d89f4a4673eec9e88fab1d3794689be5459169ee to 18651be9f1bd69e38e6ae641a5486e525efffcec

Branch pushed to git repo; I updated commit sha1. New commits:

18651beMerge branch 'u/chapoton/14444' in 7.4.b2

comment:27 Changed 4 years ago by git

  • Commit changed from 18651be9f1bd69e38e6ae641a5486e525efffcec to cc6b97f10c09be4ff44b4de42794120da7c0f52a

Branch pushed to git repo; I updated commit sha1. New commits:

cc6b97fMerge branch 'u/chapoton/14444' in 8.0.b9
Note: See TracTickets for help on using tickets.