Opened 7 years ago
Last modified 6 years ago
#14434 closed enhancement
Implement feedback_vertex_set for graphs — at Version 11
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | graph theory | Keywords: | |
Cc: | tmonteil, vdelecroix, dimpase, kini | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14435 | Stopgaps: |
Change History (15)
Changed 7 years ago by
comment:1 Changed 7 years ago by
- Dependencies set to #14435
- Status changed from new to needs_review
Changed 7 years ago by
comment:2 Changed 6 years ago by
- Status changed from needs_review to needs_work
- Work issues set to doctest
comment:3 follow-up: ↓ 4 Changed 6 years ago by
Did you by any chance install CPLEX or a LP solver which is not GLPK ? :-P
Nathann
comment:4 in reply to: ↑ 3 Changed 6 years ago by
Replying to ncohen:
Did you by any chance install CPLEX or a LP solver which is not GLPK ?
:-P
Nope. And patchbot neither.
comment:5 Changed 6 years ago by
Yep. Most probably because I am the one who installed it, and I did not remember >_<
Nathann
comment:6 Changed 6 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
Updated. Sorryyyyyyyyyyyyyyyyyyyyyyyyyyyyy ^^;
Nathann
Changed 6 years ago by
comment:7 follow-up: ↓ 8 Changed 6 years ago by
- Description modified (diff)
- Work issues doctest deleted
I update a patch with several corrections in the documentation. If you are happy, make it positive review.
Two curiosities:
I just learn that for verbosity, there is sage.misc.misc.verbose
.
Why
[v for v in self if p.get_values(b[v]) < .5]
instead of
[v for v in self if p.get_values(b[v]) == 0.]
comment:8 in reply to: ↑ 7 Changed 6 years ago by
Yoooooooooooooooo !!!
I just learn that for verbosity, there is
sage.misc.misc.verbose
.
>_<
Yeah... Right >_<
Pretty good idea... But this will require a LARGE patch :-PPPPPP
I have one thousand different functions with a verbosity level, though most of them are LP-related. I wonder if it's a good idea to have a global function to do that rather than a flag for each function... HMmmmmmm O_o
Why
[v for v in self if p.get_values(b[v]) < .5]instead of
[v for v in self if p.get_values(b[v]) == 0.]
Because this is old code, written before integer values were automatically rounded. I will update this in a second.
Nathann
Changed 6 years ago by
comment:9 Changed 6 years ago by
Here it is ! Patch updated to fix a couple of .5 that remained. Could you give it a final check, and set the ticket to positive review if you agree ? Thanks for your changes to the doc !
Nathann
comment:10 Changed 6 years ago by
- Milestone changed from sage-5.10 to sage-5.11
- Status changed from needs_review to positive_review
To twist the alphabetic logic of patchbot:
apply trac_14434-move.patch trac_14434.patch trac_14434-doctest.patch trac_14434-clean_doc.patch Download
comment:11 Changed 6 years ago by
- Description modified (diff)