Opened 7 years ago

Closed 7 years ago

#14433 closed defect (fixed)

Increase number of matches to "tree" in sagedoc.py doctest

Reported by: jdemeyer Owned by: mvngu
Priority: blocker Milestone: sage-5.10
Component: doctest coverage Keywords:
Cc: Merged in: sage-5.10.beta0
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: merge with #8703 Stopgaps:

Description


Attachments (1)

14433_search_doc.patch (1004 bytes) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by jdemeyer

comment:1 Changed 7 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by jdemeyer

  • Dependencies set to merge with #8703

comment:3 Changed 7 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

With #8703, I got this on 5.9.beta5:

sage -t --long misc/sagedoc.py
**********************************************************************
File "misc/sagedoc.py", line 1039, in sage.misc.sagedoc.?
Failed example:
    len(search_doc('tree', interact=False).splitlines()) > 4000  # long time
Expected:
    True
Got:
    False

comment:4 Changed 7 years ago by jdemeyer

Are you sure you remembered to run make doc after applying the patch?

comment:5 Changed 7 years ago by tscrim

  • Status changed from needs_review to positive_review

No I didn't. I ran it and it passed all tests.

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.10.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.