Rewrite the sage-cleaner
Reported by: |
vbraun |
Owned by: |
leif |
Priority:
|
major
|
Milestone:
|
|
Component:
|
scripts
|
Keywords:
|
|
Cc:
|
|
Merged in:
|
|
Authors:
|
|
Reviewers:
|
|
Report Upstream:
|
N/A
|
Work issues:
|
|
Branch:
|
|
Commit:
|
|
Dependencies:
|
|
Stopgaps:
|
|
Its still bad. Here is a wishlist:
- don't continuously restart the sage cleaner during doctests
- make it part of the sage library to get rid of the code duplication for temporary directories that keeps breaking the cleaner
- in particular, make it doctestable
- Entries in
spawned_processes
are killed by the cleaner and by sage.interfaces.quit.expect_quitall()
.
- avoid potential races with PID wrap-around: Sage should announce its shutdown to the cleaner.
- Ensure (and doctest) that the temp directory with given PID is deleted before Sage starts. Even if the cleaner doesn't work we must not kill stuff from old
spawned_process
files.
Change History (7)
Milestone: |
sage-5.11 →
sage-5.12
|
Milestone: |
sage-6.1 →
sage-6.2
|
Milestone: |
sage-6.2 →
sage-6.3
|
Milestone: |
sage-6.3 →
sage-6.4
|
Replying to vbraun:
Not sure if that makes sense. People should take more care when changing such parts... ;-)
In any case, "both parts" should of course somehow use the same interface (i.e., directories etc.), which doesn't or shouldn't require code duplication. It should IMHO still be possible to run a single instance of the Sage cleaner for different (running) Sage versions, or, at the very least, the cleaner(s) shouldn't break when running different Sage versions at the same time.