Opened 9 years ago

Closed 9 years ago

#14430 closed enhancement (fixed)

doctesting enhancements

Reported by: vbraun Owned by: roed
Priority: major Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: jdemeyer Merged in: sage-5.9.beta5
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

The die_timeout is too short if you run with low priority, its not that uncommon for my patchbot to hang for 5 seconds if a foreground process is active. Also, print the pid of the process if there is a problem, so one can compare with logs what happened.

Apply trac_14430_longer_timeout.patch, trac_14430_report_worker_pid.patch

Attachments (2)

trac_14430_longer_timeout.patch (1.9 KB) - added by vbraun 9 years ago.
Initial patch
trac_14430_report_worker_pid.patch (5.2 KB) - added by vbraun 9 years ago.
Initial patch

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by vbraun

Initial patch

Changed 9 years ago by vbraun

Initial patch

comment:1 Changed 9 years ago by vbraun

  • Cc jdemeyer added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by jdemeyer

Sounds reasonable, positive review assuming it passes doctests.

comment:3 Changed 9 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.9.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.