Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#14427 closed enhancement (fixed)

add key tableau functions to sage.combinat

Reported by: jferreira Owned by: jferreira
Priority: minor Milestone: sage-5.10
Component: combinatorics Keywords:
Cc: sage-combinat Merged in: sage-5.10.beta0
Authors: Jeffrey Ferreira Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by tscrim)

Adds three new functions to the Tableau class to compute the right and left key tableaux of a tableau and to verify a given tableau is a key tableau.

Apply: trac_14427-key_tableau-rebased.patch

Attachments (3)

trac_14427-key_tableau-review-ts.patch (5.9 KB) - added by tscrim 9 years ago.
trac_14427_key_tableau.patch (6.6 KB) - added by jferreira 9 years ago.
trac_14427-key_tableau-rebased.patch (6.6 KB) - added by tscrim 9 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by jferreira

  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Hey Jeff,

I've uploaded a review patch which reworks the documentation a little bit. If you could describe the algorithm to create the left/right key tableaux in less than 10 lines or so, could you please write that in (and fold the two patches if you have any other changes to make too). Otherwise if you agree with my changes, feel free to set this to positive review.

Thanks,
Travis

comment:3 in reply to: ↑ 2 Changed 9 years ago by jferreira

Travis, Thanks for taking a look at my first attempt at a sage patch. I tried applying your patch but got this error:

patching file sage/combinat/tableau.py Hunk #3 FAILED at 2314 1 out of 3 hunks FAILED -- saving rejects to file sage/combinat/tableau.py.rej abort: patch failed to apply

This might be my error since I'm new at this, I'm not sure. However, the patch still shows your suggestions clearly and I'll work up another patch to incorporate them.

-Jeff

Replying to tscrim:

Hey Jeff,

I've uploaded a review patch which reworks the documentation a little bit. If you could describe the algorithm to create the left/right key tableaux in less than 10 lines or so, could you please write that in (and fold the two patches if you have any other changes to make too). Otherwise if you agree with my changes, feel free to set this to positive review.

Thanks,
Travis

Changed 9 years ago by tscrim

comment:4 Changed 9 years ago by tscrim

I've uploaded a slightly tweaked patch, so give that a try. There may also be a dependence on #14299 but I don't think so.

comment:5 Changed 9 years ago by jferreira

Uploaded new patch incorporating suggestions from tscrim.

comment:6 Changed 9 years ago by tscrim

  • Description modified (diff)

Hey Jeff,

In the descriptions of left/right_key_tableau(), could you format it in latex using single backticks as `T` instead of code (as double backticks ``T``) in everything but the first line. In case you are unaware, you can view the documentation (for the combinat directory) by running sage -docbuild reference/combinat html.

Looks good otherwise. Thanks,
Travis

Changed 9 years ago by jferreira

comment:7 Changed 9 years ago by jferreira

Travis -  I fixed the documentation problems. Let me know what you think. Thanks. -Jeff

Changed 9 years ago by tscrim

comment:8 Changed 9 years ago by tscrim

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Hey Jeff,

Looks good now. Thanks.

I've uploaded your patch rebased to 5.9.beta5 so that it applies cleanly (i.e. with no "fuzz").

Thanks,
Travis

For patchbot:

Apply: trac_14427-key_tableau-rebased.patch

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.10.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 8 years ago by jferreira

  • Authors changed from Jeff Ferreira to Jeffrey Ferreira
Note: See TracTickets for help on using tickets.