#14427 closed enhancement (fixed)
add key tableau functions to sage.combinat
Reported by: | Jeffrey Ferreira | Owned by: | Jeffrey Ferreira |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.10 |
Component: | combinatorics | Keywords: | |
Cc: | Sage Combinat CC user | Merged in: | sage-5.10.beta0 |
Authors: | Jeffrey Ferreira | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Adds three new functions to the Tableau class to compute the right and left key tableaux of a tableau and to verify a given tableau is a key tableau.
Attachments (3)
Change History (13)
comment:1 Changed 10 years ago by
Status: | new → needs_review |
---|
comment:2 follow-up: 3 Changed 10 years ago by
Reviewers: | → Travis Scrimshaw |
---|
comment:3 Changed 10 years ago by
Travis, Thanks for taking a look at my first attempt at a sage patch. I tried applying your patch but got this error:
patching file sage/combinat/tableau.py Hunk #3 FAILED at 2314 1 out of 3 hunks FAILED -- saving rejects to file sage/combinat/tableau.py.rej abort: patch failed to apply
This might be my error since I'm new at this, I'm not sure. However, the patch still shows your suggestions clearly and I'll work up another patch to incorporate them.
-Jeff
Replying to tscrim:
Hey Jeff,
I've uploaded a review patch which reworks the documentation a little bit. If you could describe the algorithm to create the left/right key tableaux in less than 10 lines or so, could you please write that in (and fold the two patches if you have any other changes to make too). Otherwise if you agree with my changes, feel free to set this to positive review.
Thanks,
Travis
Changed 10 years ago by
Attachment: | trac_14427-key_tableau-review-ts.patch added |
---|
comment:4 Changed 10 years ago by
I've uploaded a slightly tweaked patch, so give that a try. There may also be a dependence on #14299 but I don't think so.
comment:6 Changed 10 years ago by
Description: | modified (diff) |
---|
Hey Jeff,
In the descriptions of left/right_key_tableau()
, could you format it in latex using single backticks as `T`
instead of code (as double backticks ``T``
) in everything but the first line. In case you are unaware, you can view the documentation (for the combinat directory) by running sage -docbuild reference/combinat html
.
Looks good otherwise. Thanks,
Travis
Changed 10 years ago by
Attachment: | trac_14427_key_tableau.patch added |
---|
comment:7 Changed 10 years ago by
Travis - I fixed the documentation problems. Let me know what you think. Thanks. -Jeff
Changed 10 years ago by
Attachment: | trac_14427-key_tableau-rebased.patch added |
---|
comment:8 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_review → positive_review |
Hey Jeff,
Looks good now. Thanks.
I've uploaded your patch rebased to 5.9.beta5
so that it applies cleanly (i.e. with no "fuzz").
Thanks,
Travis
For patchbot:
Apply: trac_14427-key_tableau-rebased.patch
comment:9 Changed 10 years ago by
Merged in: | → sage-5.10.beta0 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:10 Changed 9 years ago by
Authors: | Jeff Ferreira → Jeffrey Ferreira |
---|
Hey Jeff,
I've uploaded a review patch which reworks the documentation a little bit. If you could describe the algorithm to create the left/right key tableaux in less than 10 lines or so, could you please write that in (and fold the two patches if you have any other changes to make too). Otherwise if you agree with my changes, feel free to set this to positive review.
Thanks,
Travis