Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14423 closed enhancement (fixed)

python-2.7.4

Reported by: vbraun Owned by: jdemeyer
Priority: major Milestone: sage-5.10
Component: packages: standard Keywords:
Cc: jdemeyer, jpflori Merged in: sage-5.10.beta1
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14477 Stopgaps:

Status badges

Attachments (2)

trac_14423_python_274.patch (761 bytes) - added by vbraun 8 years ago.
Initial patch
python-2.7.4.p0.diff (2.1 KB) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 8 years ago by vbraun

  • Cc jdemeyer added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by jdemeyer

  • Status changed from needs_review to needs_work

You must keep the order in patches/ncurses-issue_9665.patch: configure.ac should be patched first, then configure, otherwise Makefile will think it needs to run autoconf again.

comment:3 Changed 8 years ago by jdemeyer

  • Description modified (diff)
  • Reviewers set to Jeroen Demeyer

comment:4 Changed 8 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:5 Changed 8 years ago by vbraun

  • Status changed from needs_review to positive_review

Looks good to me...

comment:6 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work

I'm not entirely sure, but this seems to cause

sage -t --long devel/sage/sage/misc/prandom.py
**********************************************************************
File "devel/sage/sage/misc/prandom.py", line 320, in sage.misc.prandom.vonmisesvariate
Failed example:
    [vonmisesvariate(1.0r, 3.0r) for i in range(1, 5)]
Expected:
    [0.8983286393554258, 0.6718030007041285, 2.0308777524813397, 1.714325253725145...]
Got:
    [0.898328639355427, 0.6718030007041281, 2.0308777524813393, 1.714325253725145]
**********************************************************************

Changed 8 years ago by vbraun

Initial patch

comment:7 Changed 8 years ago by vbraun

  • Description modified (diff)
  • Status changed from needs_work to needs_review

Looks like vonmisesvariate was changed to RNDN rounding mode. Oh well...

comment:8 Changed 8 years ago by jpflori

  • Cc jpflori added
  • Description modified (diff)

Changed 8 years ago by jdemeyer

comment:9 Changed 8 years ago by jdemeyer

Positive review to your patch.

Volker: I added a patch to the spkg to get rid of the silly warnings about -Wstrict-prototypes not being valid for C++. Please review (spkg diff here)

comment:10 Changed 8 years ago by vbraun

  • Status changed from needs_review to positive_review

Sounds good to me.

comment:11 Changed 8 years ago by jdemeyer

  • Dependencies set to #14477
  • Milestone changed from sage-5.10 to sage-pending

There is a problem with (non-)sorting of SQL query results: #14477.

comment:12 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-pending to sage-5.10

comment:13 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:14 Changed 8 years ago by leif

Upgrade to 2.7.5 is #14600.

Note: See TracTickets for help on using tickets.