Opened 4 years ago
Closed 4 years ago
#14413 closed enhancement (fixed)
Implementation of elementary crystals
Reported by: | bsalisbury1 | Owned by: | bsalisbury1 |
---|---|---|---|
Priority: | major | Milestone: | sage-5.11 |
Component: | combinatorics | Keywords: | crystal |
Cc: | sage-combinat, aschilling, tscrim | Merged in: | sage-5.11.beta1 |
Authors: | Ben Salisbury | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13735 #14402 | Stopgaps: |
Description (last modified by )
Implements the crystals T_lambda, R_lambda, C, and B_i for all types.
Attachments (1)
Change History (17)
comment:1 Changed 4 years ago by
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Status changed from needs_review to needs_work
comment:3 Changed 4 years ago by
- Status changed from needs_work to needs_review
comment:4 Changed 4 years ago by
- Description modified (diff)
- Milestone changed from sage-5.9 to sage-5.10
comment:5 Changed 4 years ago by
- Milestone changed from sage-5.10 to sage-pending
- Status changed from needs_review to positive_review
comment:6 Changed 4 years ago by
- Dependencies set to #14402
comment:7 Changed 4 years ago by
Hey Ben,
Could you reupload the version of the patch on the combinat queue? I had to make some minor tweaks due changes in #14402.
Thanks,
Travis
comment:8 Changed 4 years ago by
It's re-uploaded. Thanks, Travis and Anne, for reviewing and adjusting!
comment:9 follow-up: ↓ 10 Changed 4 years ago by
- Milestone changed from sage-pending to sage-5.11
Thanks Ben.
comment:10 in reply to: ↑ 9 Changed 4 years ago by
Why does this patch import ../sage/combinat/crystals/kyoto_path_model into the documentation? That does not seem to exist.
So I set this back to needs work.
Best,
Anne
comment:11 follow-up: ↓ 12 Changed 4 years ago by
- Status changed from positive_review to needs_work
comment:12 in reply to: ↑ 11 Changed 4 years ago by
In addition, I unfortunately get test failures:
sage -t elementary_crystals.py ********************************************************************** File "elementary_crystals.py", line 335, in sage.combinat.crystals.elementary_crystals.TCrystal.Element._latex_ Failed example: latex(t) Expected: {t_{\left(-1\right)e_{0} + \left(-3\right)e_{1} + \left(-3\right)e_{2} + \left(-3\right)e_{deltacheck}}} Got: {t_{-e_{0} - 3e_{1} - 3e_{2} - 3e_{deltacheck}}} ********************************************************************** File "elementary_crystals.py", line 563, in sage.combinat.crystals.elementary_crystals.RCrystal.Element._latex_ Failed example: latex(r) Expected: {r_{e_{0} + \left(-1\right)e_{2}}} Got: {r_{e_{0} - e_{2}}} **********************************************************************
Changed 4 years ago by
comment:13 Changed 4 years ago by
- Status changed from needs_work to needs_review
comment:14 Changed 4 years ago by
Thank you, Anne, for pointing this out, and thank you, Travis, for your help!
comment:15 Changed 4 years ago by
- Dependencies changed from #14402 to #13735 #14402
- Status changed from needs_review to positive_review
Failing doctests were due to #13735. Idk how I mistakenly put the kyoto_path_model
into the rst file... Thanks for catching this Anne.
comment:16 Changed 4 years ago by
- Merged in set to sage-5.11.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Thanks for your work on this Ben.