Opened 9 years ago

Closed 9 years ago

#14397 closed task (fixed)

prepare sage library for cythonizing out of place

Reported by: ohanar Owned by: jason
Priority: major Milestone: sage-5.10
Component: misc Keywords:
Cc: robertwb Merged in: sage-5.10.beta0
Authors: R. Andrew Ohana Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by ohanar)

This will allow us to enable cythonize the sage library out of place in the future (see This will make it much easier to clean up sage and much nicer greping through the sage library source.

Apply trac14397.patch to the sage library.

Attachments (1)

trac14397.patch (4.6 KB) - added by ohanar 9 years ago.
apply to sage library

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by ohanar

  • Cc robertwb added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by jdemeyer

Mercurial supports renaming files: no need to delete sage/libs/eclsig.c and create sage/libs/eclsig.h, you can do

hg mv sage/libs/eclsig.c sage/libs/eclsig.h

comment:3 Changed 9 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

Apart from the Mercurial issue, this patch looks good.

Changed 9 years ago by ohanar

apply to sage library

comment:4 Changed 9 years ago by ohanar

  • Status changed from needs_review to positive_review

Ok, fixed the patch.

comment:5 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.9 to sage-5.10

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.10.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.