Opened 6 years ago

Closed 6 years ago

#14394 closed enhancement (fixed)

FaceFan bug if origin is on boundary

Reported by: vbraun Owned by: mhampton
Priority: major Milestone: sage-5.10
Component: geometry Keywords: toric
Cc: novoselt Merged in: sage-5.10.beta0
Authors: Volker Braun Reviewers: Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13194 Stopgaps:

Description

If the origin is on the boundary of the polytope then FaceFan fails to raise an appropriate error:

sage: FaceFan(Polyhedron([(-1,0), (1,0), (0,1)])).generating_cones()       
(2-d cone of Rational polyhedral fan in 2-d lattice N,
 1-d cone of Rational polyhedral fan in 2-d lattice N,
 2-d cone of Rational polyhedral fan in 2-d lattice N)

Attachments (2)

trac_14394_face_fan_bug.patch (2.5 KB) - added by vbraun 6 years ago.
Initial patch
trac_14394_reviewer.patch (2.5 KB) - added by novoselt 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by vbraun

  • Authors set to Volker Braun
  • Dependencies set to #13194

Changed 6 years ago by vbraun

Initial patch

comment:2 Changed 6 years ago by vbraun

  • Cc novoselt added
  • Status changed from new to needs_review

Changed 6 years ago by novoselt

comment:3 Changed 6 years ago by novoselt

  • Keywords toric added
  • Reviewers set to Andrey Novoseltsev

Some tweaks to documentation and switch to NotImplementedError left from #13194, please switch to positive review if changes are OK!

comment:4 Changed 6 years ago by vbraun

  • Status changed from needs_review to positive_review

Thanks, looks good to me.

comment:5 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.9 to sage-5.10

comment:6 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.10.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.