#14393 closed task (fixed)
Clean SAGE_ROOT from module_list.py (again)
Reported by: | fbissey | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | major | Milestone: | sage-5.9 |
Component: | build | Keywords: | |
Cc: | ohanar, cschwan | Merged in: | sage-5.9.beta5 |
Authors: | François Bissey | Reviewers: | Christopher Schwan |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
A few tickets have been using SAGE_ROOT directly or not used SAGE_INC since my last clean up. After cleaning direct calls to SAGE_ROOT in the rest of sage we need to spend some time here.
The use of SAGE_INC has also been normalized everywhere so it is not necessary to add a final "/". The use of predefined depend variables has been enforced as much as I could see it.
Apply to the sage library:
Attachments (1)
Change History (11)
comment:1 Changed 6 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Cc cschwan added
Could you have a look at this Christopher? I was hoping Andrew would be interested but he must be busy elsewhere. I'd very much want to see this in 5.9.
comment:3 Changed 6 years ago by
Looks good to me. Do you want me to test it as well? I could do this at the weekend.
comment:4 follow-up: ↓ 10 Changed 6 years ago by
It should be done properly, so yes testing. Testing is the only way to see if I missed something, which I don't think I did.
comment:5 Changed 6 years ago by
OK, I will test it this weekend.
comment:6 Changed 6 years ago by
I checked with beta2; patch applies cleanly and the build is fine.
comment:7 Changed 6 years ago by
- Reviewers set to Christopher Schwan
- Status changed from needs_review to positive_review
OK I put it in positive review then.
comment:8 Changed 6 years ago by
comment:9 Changed 6 years ago by
- Merged in set to sage-5.9.beta5
- Resolution set to fixed
- Status changed from positive_review to closed
It has been bothering me for a while that a few people have been using naked SAGE_ROOT in there.