Opened 8 years ago

Closed 8 years ago

#14376 closed enhancement (fixed)

Add doctest directory to the reference manual

Reported by: jdemeyer Owned by: mvngu
Priority: major Milestone: sage-5.9
Component: documentation Keywords:
Cc: jhpalmieri, roed Merged in: sage-5.9.beta3
Authors: John Palmieri Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14370 Stopgaps:

Description


Attachments (1)

trac_14376.patch (12.5 KB) - added by jhpalmieri 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by jhpalmieri

  • Authors set to John Palmieri
  • Cc roed added
  • Status changed from new to needs_review

Here's an initial patch.

comment:2 Changed 8 years ago by jhpalmieri

  • Dependencies set to #14370

Changed 8 years ago by jhpalmieri

comment:3 Changed 8 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_work

Your patch actually breaks doctesting sage/doctest/forker.py because of line number changes.

comment:4 follow-up: Changed 8 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

The patch from 16 hours ago failed doctesting, but the one from 11 hours ago fixed those line numbers, at least for me. Can you make sure you used the right patch?

comment:5 in reply to: ↑ 4 ; follow-up: Changed 8 years ago by jdemeyer

Replying to jhpalmieri:

Can you make sure you used the right patch?

I guess I didn't, but the ticket was at "needs review" when I tried it :-)

comment:6 in reply to: ↑ 5 Changed 8 years ago by jhpalmieri

Replying to jdemeyer:

Replying to jhpalmieri:

Can you make sure you used the right patch?

I guess I didn't, but the ticket was at "needs review" when I tried it :-)

I know, sorry, but then I found the doctest errors and fixed them without saying anything, only posting a new patch.

comment:7 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.9.beta3
  • Resolution set to fixed
  • Status changed from needs_review to closed

Looks good to me.

Note: See TracTickets for help on using tickets.