Opened 10 years ago
Closed 10 years ago
#14342 closed enhancement (fixed)
Remove references to `DOT_SAGE/tmp`
Reported by: | John Palmieri | Owned by: | Georg S. Weber |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.9 |
Component: | build | Keywords: | |
Cc: | Jeroen Demeyer | Merged in: | sage-5.9.beta2 |
Authors: | John Palmieri | Reviewers: | Keshav Kini, Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I think that spkg/bin/sage-env
is the only place in Sage which refers to DOT_SAGE/tmp
:
if [ -z "$SAGE_TESTDIR" ]; then SAGE_TESTDIR="$DOT_SAGE"/tmp && export SAGE_TESTDIR fi
So this could be changed from tmp
to temp
.
Patches attached.
Attachments (4)
Change History (12)
Changed 10 years ago by
Attachment: | trac_14342-sagelib.patch added |
---|
comment:1 Changed 10 years ago by
Status: | new → needs_review |
---|
comment:2 Changed 10 years ago by
Reviewers: | → Keshav Kini |
---|---|
Status: | needs_review → positive_review |
Looks good to me.
comment:3 follow-up: 4 Changed 10 years ago by
Can't we simply get rid of SAGE_TESTDIR
for now? I don't think the logfile for the testing is that important and besides, this would change anyway in the git layout.
comment:4 follow-up: 5 Changed 10 years ago by
Replying to jdemeyer:
Can't we simply get rid of
SAGE_TESTDIR
for now?
That's fine with me. What should we use for the default location for the logfile?
doctest/control.py is the only place SAGE_TESTDIR
is used:
if options.all and options.logfile is None: options.logfile = os.path.join(os.environ['SAGE_TESTDIR'], 'test.log')
comment:5 Changed 10 years ago by
Replying to jhpalmieri:
Replying to jdemeyer:
Can't we simply get rid of
SAGE_TESTDIR
for now?That's fine with me. What should we use for the default location for the logfile?
None. I don't think it is particularly important to have a default logfile.
comment:6 Changed 10 years ago by
Here are new patches. I've left the originals here, since they have a positive review. But we can use the "v2" patches instead if people prefer.
comment:7 Changed 10 years ago by
Reviewers: | Keshav Kini → Keshav Kini, Jeroen Demeyer |
---|
The v2 patches look good to me, David Roe also agrees if that matters.
comment:8 Changed 10 years ago by
Merged in: | → sage-5.9.beta2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Sage library: documentation