#14336 closed enhancement (fixed)
update M4RIE to version 20130416
Reported by: | malb | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-5.10 |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | sage-5.10.beta1 | |
Authors: | Martin Albrecht | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14335 | Stopgaps: |
Description (last modified by )
M4RIE version 20130416 extends the supported finite field size to 2^{16} (from 2^{10}). Furthermore, it can be built with 256MB of RAM.
Install http://boxen.math.washington.edu/home/malb/spkgs/libm4rie-20130416.spkg
Apply m4rie_new_version.patch
Attachments (1)
Change History (16)
comment:1 Changed 8 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Dependencies set to #14335
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
Please don't make needless whitespace changes. Those will only lead to merge conflicts and makes it harder to review.
comment:5 Changed 8 years ago by
Yeah, sorry bout that. I'll not do it again.
comment:6 Changed 8 years ago by
- Description modified (diff)
Can you take out the empty patch hunks (pure whitespace)?
comment:7 Changed 8 years ago by
Also, the patch doesn't apply to sage-5.9.beta5
comment:8 Changed 8 years ago by
I've rebased the patch and stripped whitespace only changes. The patch is still relatively large (50K) because the randomness source of random_matrix changed for some matrices (it's not driven by Givaro any more)
Changed 8 years ago by
comment:9 Changed 8 years ago by
Updated patch to fix a doctest failure which was caused by some whitespace change.
comment:10 Changed 8 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
Positive review
comment:11 Changed 8 years ago by
- Milestone changed from sage-5.9 to sage-5.10
comment:12 Changed 8 years ago by
- Merged in set to sage-5.10.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:13 Changed 8 years ago by
when I try to import the patch in Sage 5.9 (with hg_sage.import_patch("/tmp/m4rie_new_version.patch")
), I get a diff -git
output,
then it enters my editor. It seems a commit log is missing in this patch.
Paul
comment:14 Changed 8 years ago by
after adding a dummy commit log message, I get:
Cythonizing sage/matrix/matrix_double_dense.pyx warning: sage/matrix/matrix_double_dense.pyx:1871:26: Unreachable code
Is it wanted?
Paul
comment:15 Changed 8 years ago by
Hi Paul, * strangely, enough the patch does have a commit message. Maybe the use of git style diffs is tripping things up?
- the patch (doesn't seem to) touch matrix_double_dense.pyx.
It took two hours to compile it on my arm box, and the desktop interface was still running. Compared to the previous version which needed me to shut down X and kill as many services as possible, and where conversion.c took just by itself about six hours to compile, I think I can say this is a marked improvement!
Congrats!