Opened 10 years ago
Closed 10 years ago
#14335 closed enhancement (fixed)
update M4RI to version 20130416
Reported by: | Martin Albrecht | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.10 |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | sage-5.10.beta1 | |
Authors: | Martin Albrecht | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
20130416 is mainly maintenance release of M4RI improving performance for small matrices.
Release notes are here: https://bitbucket.org/malb/m4ri/wiki/M4RI-20130416
Install http://boxen.math.washington.edu/home/malb/spkgs/libm4ri-20130416.spkg
Change History (8)
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Status: | new → needs_review |
comment:2 Changed 10 years ago by
comment:4 Changed 10 years ago by
I looked at libm4rie's compilation and found there where many warnings ; I checked libm4ri's build log, and found that many, many files trigger the following warnings:
In file included from ./m4ri/mzd.h:45:0, from m4ri/brilliantrussian.h:41, from m4ri/brilliantrussian.c:28: ./m4ri/misc.h:577:0: warning: "__M4RI_CPU_L3_CACHE" redefined [enabled by default] In file included from ./m4ri/mzd.h:35:0, from m4ri/brilliantrussian.h:41, from m4ri/brilliantrussian.c:28: ./m4ri/m4ri_config.h:11:0: note: this is the location of the previous definition In file included from ./m4ri/mzd.h:45:0, from m4ri/brilliantrussian.h:41, from m4ri/brilliantrussian.c:28: ./m4ri/misc.h:586:0: warning: "__M4RI_CPU_L2_CACHE" redefined [enabled by default] In file included from ./m4ri/mzd.h:35:0, from m4ri/brilliantrussian.h:41, from m4ri/brilliantrussian.c:28: ./m4ri/m4ri_config.h:10:0: note: this is the location of the previous definitionIn file included from ./m4ri/mzd.h:45:0, from m4ri/brilliantrussian.h:41, from m4ri/brilliantrussian.c:28: ./m4ri/misc.h:595:0: warning: "__M4RI_CPU_L1_CACHE" redefined [enabled by default] In file included from ./m4ri/mzd.h:35:0, from m4ri/brilliantrussian.h:41, from m4ri/brilliantrussian.c:28: ./m4ri/m4ri_config.h:9:0: note: this is the location of the previous definition
It doesn't harm but obfuscates the logs and perhaps means there's some header file missing guards.
comment:5 Changed 10 years ago by
Those warnings are expected. It means that L1-L3 were not detected successfully and are replaced by default values. So it's not critical. It might make sense to investigate how to detect L1/L2 on your kind of boxes (for future releases) and we should also print a less scary warning once.
comment:6 Changed 10 years ago by
Authors: | → Martin Albrecht |
---|---|
Reviewers: | → Volker Braun |
Status: | needs_review → positive_review |
Looks good to me.
comment:7 Changed 10 years ago by
Milestone: | sage-5.9 → sage-5.10 |
---|
comment:8 Changed 10 years ago by
Merged in: | → sage-5.10.beta1 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
FWIW, I just built Sage 5.8 from scratch with the SPKG linked above on bsd.math.washington.edu.