Opened 10 years ago

Last modified 9 years ago

#14333 closed defect

singular-3-1-6 is out — at Version 16

Reported by: Julien Puydt Owned by: tbd
Priority: major Milestone: sage-6.2
Component: packages: standard Keywords: spkg, sd53
Cc: Jean-Pierre Flori Merged in:
Authors: Burcin Erocal Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13770 Stopgaps:

Status badges

Description (last modified by Burcin Erocal)

http://www.singular.uni-kl.de/index.php/news/release-of-singular-3-1-6.html


Sage should probably upgrade to this version; it won't be painless though, since my experiments show that what in the changelog is lightly documented as "interface to iiMake_proc changed" (in the "Internal changes" section) -- impacts sage. The API for iiMake_proc changed from

sleftv * iiMake_proc(idhdl pn, package pack, sleftv* sl);

to

BOOLEAN iiMake_proc(idhdl pn, package pack, sleftv* sl);

Probably also take care of #12442.

spkg: http://sage.math.washington.edu/home/burcin/singular-3-1-6.p0.spkg

Change History (17)

comment:1 Changed 10 years ago by Leif Leonhardy

Description: modified (diff)
Keywords: spkg added

comment:2 Changed 10 years ago by Leif Leonhardy

The patch from #14295 would have to get updated as well (as there's now one more instance of calling floor() with an int; they also added some superfluous casts, so the patch probably wouldn't apply anyway).

comment:3 Changed 10 years ago by Julien Puydt

Wasn't that patch already updated before you submitted it on upstream's trac?

comment:4 in reply to:  3 Changed 10 years ago by Leif Leonhardy

Replying to Snark:

Wasn't that patch already updated before you submitted it on upstream's trac?

Pardon?

(I haven't submitted a patch upstream, but only a bug report. The patch from #14295 is of course against 3-1-5, our current version, not 3-1-6.)

comment:5 Changed 10 years ago by Julien Puydt

Oh, sorry, indeed.

comment:6 Changed 10 years ago by Jean-Pierre Flori

Cc: Jean-Pierre Flori added

comment:7 Changed 10 years ago by Burcin Erocal

Priority: minormajor
Type: enhancementdefect

I'm modifying the ticket priority since it fixes some problems with multivariate polynomial factorization (#14658).

comment:8 in reply to:  7 Changed 10 years ago by Leif Leonhardy

Replying to burcin:

I'm modifying the ticket priority since it fixes some problems with multivariate polynomial factorization (#14658).

Upgrading Singular is still (hopefully) an enhancement, not a defect. (Unless you change the ticket's subject...)

comment:9 Changed 10 years ago by Leif Leonhardy

Description: modified (diff)

comment:10 Changed 9 years ago by Leif Leonhardy

Just to make you aware of #14737.

comment:11 Changed 9 years ago by Jean-Pierre Flori

It would also be nice to backport the fix needed by NTL 6.0.0: see #14876 and https://groups.google.com/d/msg/libsingular-devel/aiMvEnN8qyg/cIFUsOXxK_MJ

comment:12 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:13 Changed 9 years ago by Jeroen Demeyer

Description: modified (diff)

comment:14 Changed 9 years ago by Jeroen Demeyer

Dependencies: #13770

I'm looking into this...

comment:15 Changed 9 years ago by Jeroen Demeyer

Description: modified (diff)

Changed 9 years ago by Burcin Erocal

comment:16 Changed 9 years ago by Burcin Erocal

Authors: Burcin Erocal
Description: modified (diff)
Keywords: sd53 added

I uploaded a patch to take care of the API change.

New (preliminary) spkg adds two commits from singular git (1 and 2) to add compatibility with NTL 6 (#14867) and some template instantiation errors from gcc 4.7. I didn't check if the NTL stuff works.

Note: See TracTickets for help on using tickets.