Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14328 closed enhancement (fixed)

Simplify test* targets in top-level Makefile and move logs to logs/

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: minor Milestone: sage-5.9
Component: build Keywords:
Cc: roed, leif Merged in: sage-5.9.beta4
Authors: Jeroen Demeyer, John Palmieri Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Replace

$(PIPE) "./sage -t --sagenb $(TESTDIRS) 2>&1" "tee -a test.log"

by

./sage -t --all --logfile=logs/test.log

and analogous for other test targets.

Apply 14328_makefile_doctest_opts.patch to SAGE_ROOT, and apply trac_14328-scripts.patch to local/bin.

Attachments (3)

trac_14328-scripts.patch (1.3 KB) - added by jhpalmieri 7 years ago.
trac14328_hgignore.patch (386 bytes) - added by ohanar 7 years ago.
apply to root repository
14328_makefile_doctest_opts.patch (4.3 KB) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 Changed 7 years ago by jdemeyer

  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 7 years ago by leif

  • Cc leif added

comment:3 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Status changed from new to needs_review

comment:4 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work

comment:5 Changed 7 years ago by jdemeyer

  • Status changed from needs_work to needs_review
  • Summary changed from Simplify test* targets in top-level Makefile to Simplify test* targets in top-level Makefile and move logs to logs/

comment:6 Changed 7 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to positive_review

ok, looks good and is working well

comment:7 follow-up: Changed 7 years ago by jhpalmieri

Should you document in README.txt — or in the developer guide or the installation guide — where the log file is? And/or print a message with its location if doctesting doesn't succeed? ("For more details, see ...")

comment:8 in reply to: ↑ 7 Changed 7 years ago by jdemeyer

Replying to jhpalmieri:

Should you document in README.txt — or in the developer guide or the installation guide — where the log file is? And/or print a message with its location if doctesting doesn't succeed?

We never did that, should we? Nobody ever complained about this.

comment:9 Changed 7 years ago by jhpalmieri

That's because the log file was in the same directory where you ran make ptest. Now it's hidden, at least a little.

By the way, local/bin/sage-starts should be patched too, to put start.log in logs.

comment:10 Changed 7 years ago by jhpalmieri

  • Status changed from positive_review to needs_work

Changed 7 years ago by jhpalmieri

comment:11 Changed 7 years ago by jhpalmieri

  • Authors changed from Jeroen Demeyer to Jeroen Demeyer, John Palmieri
  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:12 Changed 7 years ago by jhpalmieri

(I don't care that much about the location of the log files. If you want, we can try it as is, and if we start seeing questions on sage-release or sage-devel, then we'll fix it.)

Changed 7 years ago by ohanar

apply to root repository

comment:13 Changed 7 years ago by ohanar

  • Description modified (diff)

We should also update the hgignore to reflect the change in logs location.

comment:14 Changed 7 years ago by jdemeyer

For .hgignore, it's better to leave the old patterns in for upgrades of Sage.

comment:15 Changed 7 years ago by jdemeyer

  • Description modified (diff)

Changed 7 years ago by jdemeyer

comment:16 Changed 7 years ago by ohanar

  • Status changed from needs_review to positive_review

ok, I think all is good now (other than maybe documentation)

comment:17 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:18 Changed 7 years ago by jdemeyer

  • Merged in changed from sage-5.9.beta3 to sage-5.9.beta4
Note: See TracTickets for help on using tickets.