#14328 closed enhancement (fixed)
Simplify test* targets in top-level Makefile and move logs to logs/
Reported by: | jdemeyer | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.9 |
Component: | build | Keywords: | |
Cc: | roed, leif | Merged in: | sage-5.9.beta4 |
Authors: | Jeroen Demeyer, John Palmieri | Reviewers: | R. Andrew Ohana |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Replace
$(PIPE) "./sage -t --sagenb $(TESTDIRS) 2>&1" "tee -a test.log"
by
./sage -t --all --logfile=logs/test.log
and analogous for other test targets.
Apply 14328_makefile_doctest_opts.patch to SAGE_ROOT
, and apply trac_14328-scripts.patch to local/bin
.
Attachments (3)
Change History (21)
comment:1 Changed 8 years ago by
- Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 8 years ago by
- Cc leif added
comment:3 Changed 8 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:4 Changed 8 years ago by
- Description modified (diff)
- Status changed from needs_review to needs_work
comment:5 Changed 8 years ago by
- Status changed from needs_work to needs_review
- Summary changed from Simplify test* targets in top-level Makefile to Simplify test* targets in top-level Makefile and move logs to logs/
comment:6 Changed 8 years ago by
- Reviewers set to R. Andrew Ohana
- Status changed from needs_review to positive_review
comment:7 follow-up: ↓ 8 Changed 8 years ago by
Should you document in README.txt — or in the developer guide or the installation guide — where the log file is? And/or print a message with its location if doctesting doesn't succeed? ("For more details, see ...")
comment:8 in reply to: ↑ 7 Changed 8 years ago by
Replying to jhpalmieri:
Should you document in README.txt — or in the developer guide or the installation guide — where the log file is? And/or print a message with its location if doctesting doesn't succeed?
We never did that, should we? Nobody ever complained about this.
comment:9 Changed 8 years ago by
That's because the log file was in the same directory where you ran make ptest
. Now it's hidden, at least a little.
By the way, local/bin/sage-starts
should be patched too, to put start.log
in logs
.
comment:10 Changed 8 years ago by
- Status changed from positive_review to needs_work
Changed 8 years ago by
comment:11 Changed 8 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
trac_14328-scripts.patch needs review.
comment:12 Changed 8 years ago by
(I don't care that much about the location of the log files. If you want, we can try it as is, and if we start seeing questions on sage-release or sage-devel, then we'll fix it.)
comment:13 Changed 8 years ago by
- Description modified (diff)
We should also update the hgignore to reflect the change in logs location.
comment:14 Changed 8 years ago by
For .hgignore
, it's better to leave the old patterns in for upgrades of Sage.
comment:15 Changed 8 years ago by
- Description modified (diff)
Changed 8 years ago by
comment:16 Changed 8 years ago by
- Status changed from needs_review to positive_review
ok, I think all is good now (other than maybe documentation)
comment:17 Changed 8 years ago by
- Merged in set to sage-5.9.beta3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:18 Changed 8 years ago by
- Merged in changed from sage-5.9.beta3 to sage-5.9.beta4
ok, looks good and is working well