Changes between Initial Version and Version 1 of Ticket #14304, comment 63


Ignore:
Timestamp:
11/05/15 07:23:59 (4 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14304, comment 63

    initial v1  
    11Just a few technical comments (I don't plan to formally review this):
    2 1. You don't need to add `include_dirs = [SAGE_INC + '/flint']`
     21. You don't need to add `include_dirs = [SAGE_INC + '/flint']` (just add `flint/` to the path to the `.h` files)
    332. You don't need to add `__richcmp__` calling `_richcmp`
    443. You don't need to add `__hash__` which just raises `TypeError`: all `Element`s are now unhashable by default.
     
    1212                raise
    1313}}}
    14 given that `padic_ctx_init` is a C function, how could it ever raise a Python exception? Moreover, I find it bad style to use `except:`, you catch be more explicit and catch `except BaseException:` instead (the reason I say this is because most people write `except:` by mistake).
     14given that `padic_ctx_init` is a C function, how could it ever raise a Python exception? Moreover, I find it bad style to use `except:`, you should be more explicit and catch `except BaseException:` instead (the reason I say this is because most people write `except:` by mistake).