Opened 8 years ago

Closed 8 years ago

#14302 closed enhancement (fixed)

Adding combinatorial maps decorators to various combinatorial classes

Reported by: chrisjamesberg Owned by: Chris Berg
Priority: major Milestone: sage-5.10
Component: combinatorics Keywords: combinatorial map
Cc: tscrim, stumpc5 Merged in: sage-5.10.rc1
Authors: Chris Berg Reviewers: Christian Stump
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14123, #14140, #14197, #14255, #8703 Stopgaps:

Status badges

Description (last modified by chrisjamesberg)

Looking to add combinatorial maps decorators to several combinatorial classes. This will also solve #14258 and #14259.

Attachments (1)

trac_14302_combinatorial_maps-rebase-cs.patch (6.9 KB) - added by stumpc5 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by chrisjamesberg

  • Dependencies changed from 14123, 14140,14197, 14255,8703 to #14123, #14140, #14197, #14255, #8703

comment:2 Changed 8 years ago by chrisjamesberg

  • Description modified (diff)

comment:3 Changed 8 years ago by stumpc5

I'd give it a positive review, but it says be be depending on #14302, which doesn't apply currently... I'll likely find the time to review both tomorrow.

comment:4 Changed 8 years ago by stumpc5

  • Authors set to Chris Berg
  • Status changed from new to needs_review

comment:5 Changed 8 years ago by stumpc5

If anyone finds a min to rebase this patch: go ahead!

comment:6 Changed 8 years ago by stumpc5

  • Keywords combinatorial map added
  • Reviewers set to Christian Stump
  • Status changed from needs_review to positive_review

comment:7 follow-up: Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.10 to sage-5.11

comment:8 in reply to: ↑ 7 Changed 8 years ago by stumpc5

Replying to jdemeyer:

Dear Jeroen,

since you just merged #14123 into sage-5.10.rc0, I wonder if it would be a big deal to also merge this ticket. We have a workshop on www.FindStat.org in two weeks, and having this as well merged would make life a bit easier there.

Cheers, Christian

comment:9 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.10

comment:10 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.