Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#14295 closed defect (fixed)

Singular 3-1-5 fails to build on Solaris with GCC 4.7.x

Reported by: leif Owned by: tbd
Priority: major Milestone: sage-5.9
Component: packages: standard Keywords: ambiguous floor log10 SunOS bigintmat.cc spkg
Cc: jdemeyer Merged in: sage-5.9.beta1
Authors: Leif Leonhardy Reviewers: Jeroen Demeyer
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by leif)

This is because on Solaris, a couple of C math functions get overloaded in C++ (and Solaris' math headers put them into the global namespace).


New spkg: http://boxen.math.washington.edu/home/leif/Sage/spkgs/singular-3-1-5.p5.spkg

md5sum: 3fcadf79649e963b9d669e1161650618 singular-3-1-5.p5.spkg

singular-3-1-5.p5 (Leif Leonhardy, March 18th 2013)

  • #14295: Singular fails to build with GCC 4.7.x on Solaris. On Solaris, with __cplusplus >= 199711L, floor() and log10() are overloaded functions which get pulled into the global namespace, such that calling them with an int gets ambiguous. Patch kernel/bigintmat.cc (patches/sage_trac_14295.patch) to cast parameters to floor() and log10() from int to double, making the calls unambiguous.

Attachments (1)

singular-3-1-5.p4-p5.diff (2.6 KB) - added by leif 9 years ago.
Diff between the p4 and my p5. For reference / review only.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by leif

  • Keywords spkg added

Changed 9 years ago by leif

Diff between the p4 and my p5. For reference / review only.

comment:2 Changed 9 years ago by leif

  • Authors set to Leif Leonhardy
  • Cc jdemeyer added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:3 follow-up: Changed 9 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

Should be reported upstream.

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.9.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 9 years ago by leif

In Singular 3-1-6 (cf. #14333), there's now even one more instance of this (but in bigintmat.cc, too).

comment:6 in reply to: ↑ 3 Changed 9 years ago by leif

  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

Replying to jdemeyer:

Should be reported upstream.

Although I hate Singular's trac:

http://www.singular.uni-kl.de:8002/trac/ticket/479

comment:7 Changed 9 years ago by leif

  • Report Upstream changed from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

Will be fixed in some future Singular release (> 3-1-6).

Note: See TracTickets for help on using tickets.