Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14289 closed defect (fixed)

Doctest debugger doesn't work on OS X

Reported by: roed Owned by: mvngu
Priority: major Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: Merged in: sage-5.9.beta1
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12415 Stopgaps:

Description (last modified by jdemeyer)

sage -t --debug, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in sage.doctest.forker.SageDocTestRunner.report_unexpected_exception seem to succeed.

Can anyone else duplicate this problem on another platform?

Attachments (1)

14289_doctest_readline.patch (768 bytes) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by roed

  • Description modified (diff)

comment:2 Changed 8 years ago by jdemeyer

Did you check that it is really 12415_review.patch:ticket:12415 which breaks this and not one of the subsequent patches in #12415?

comment:3 Changed 8 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Doctest debugger doesn't work to Doctest debugger doesn't work on OS X

Adding back

import readline

in init_sage() seems to solve the problem.

Changed 8 years ago by jdemeyer

comment:4 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:5 Changed 8 years ago by roed

  • Status changed from needs_review to needs_work

Thanks for figuring out what was causing this. The only change I would suggest is using

:trac:`14249`

rather than

http://trac.sagemath.org/sage_trac/ticket/14289

comment:6 Changed 8 years ago by roed

  • Reviewers set to David Roe

comment:7 Changed 8 years ago by jdemeyer

  • Status changed from needs_work to needs_review

I think that

:trac:`14249`

should be used in and only in docstrings.

So I propose to leave the comment (unless you prefer Trac #14289 to the full URL).

comment:8 Changed 8 years ago by roed

  • Status changed from needs_review to positive_review

Yes, you're right. Then it looks fine to me.

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.9.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 8 years ago by roed

  • Component changed from doctest to doctest framework
Note: See TracTickets for help on using tickets.