Opened 7 years ago

Closed 7 years ago

#14286 closed defect (fixed)

Remove unreliable get_memory_usage() test

Reported by: jdemeyer Owned by: jason
Priority: blocker Milestone: sage-5.9
Component: misc Keywords:
Cc: Merged in: sage-5.9.beta2
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

This test sometimes fails and should be removed, since it doesn't really test anything anyway:

sage -t --long devel/sage/sage/misc/getusage.py
**********************************************************************
File "devel/sage/sage/misc/getusage.py", line 107, in sage.misc.getusage.get_memory_usage
Failed example:
    get_memory_usage(t)
Expected:
    0.0
Got:
    -0.015625
**********************************************************************

or

sage -t --long devel/sage/sage/misc/getusage.py
**********************************************************************
File "devel/sage/sage/misc/getusage.py", line 107, in sage.misc.getusage.get_memory_usage
Failed example:
    get_memory_usage(t)
Expected:
    0.0
Got:
    0.015625
**********************************************************************

Attachments (1)

14286_getusage.patch (1.5 KB) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by jdemeyer

comment:1 Changed 7 years ago by jdemeyer

  • Status changed from new to needs_review
  • Summary changed from Remove getusage() test to Remove unreliable get_memory_usage() test

comment:2 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 7 years ago by fbissey

  • Status changed from needs_review to positive_review

I am surprsed it doesn't fail more often. Not sure what the point of test is either so removal is good and definitely no side effects. Let's get it moving.

comment:4 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta2
  • Resolution set to fixed
  • Reviewers set to François Bissey
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.