Opened 7 years ago

Closed 7 years ago

#14271 closed enhancement (fixed)

Sylvester and Sims-Gewirtz graphs

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.9
Component: graph theory Keywords:
Cc: dimpase Merged in: sage-5.9.beta2
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

As the title says. Two other graphs from ​http://www.win.tue.nl/~aeb/graphs/index.html

Nathann

Attachments (3)

trac_14271-review-fc.patch​ (2.1 KB) - added by chapoton 7 years ago.
trac_14271-layouts.patch​ (1.4 KB) - added by ncohen 7 years ago.
trac_14271.patch​ (3.7 KB) - added by ncohen 7 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 7 years ago by ncohen

  • Status changed from new to needs_review

comment:2 follow-up: Changed 7 years ago by chapoton

Hello,

  • maybe add a link to :wikipedia:`Gewirtz graph` ?
  • the plots are random and not very nice
  • there should be two :: after SEEALSO

comment:3 in reply to: ↑ 2 Changed 7 years ago by ncohen

Hellooooooooo !!

  • maybe add a link to :wikipedia:`Gewirtz graph` ?

Done.

  • the plots are random and not very nice

Yes I know, but I was not able to build one that I liked, so.. :-P

  • there should be two :: after SEEALSO

Done !

Nathann

Changed 7 years ago by chapoton

comment:4 Changed 7 years ago by chapoton

Hello,

once the bot is green again, and if you agree with my review patch, you can set a positive review

comment:5 Changed 7 years ago by dimpase

  • Status changed from needs_review to positive_review

OK, this one goes in first, then! Rebase the rest of stuff pending in age/graphs/generators/smallgraphs.py.

Changed 7 years ago by ncohen

comment:6 Changed 7 years ago by ncohen

  • Status changed from positive_review to needs_work

Hello guys ! I improved my drawing scripts and ended up finding two nice layouts for these graphs. I hope that you will not mind my setting this ticket back to "needs_review", if only for a very short patch :-)

Nathann

comment:7 Changed 7 years ago by ncohen

  • Status changed from needs_work to needs_review

comment:8 Changed 7 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks better indeed. Back to positive review

comment:9 Changed 7 years ago by ncohen

Thaaaaaaaaaaaaaaaanks ! :-)

Nathann

comment:10 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_work
  • Work issues set to documentation 
dochtml.log:[graphs   ] /padic/release/merger/sage-5.9.beta2/local/lib/python2.7/site-packages/sage/graphs/graph_generators.py:docstring of sage.graphs.graph_generators.GraphGenerators.SimsGewirtzGraph:8: ERROR: Unknown target name: "http://www.win.tue.nl/~aeb/graphs/sims-gewirtz.html".
dochtml.log:[graphs   ] /padic/release/merger/sage-5.9.beta2/local/lib/python2.7/site-packages/sage/graphs/graph_generators.py:docstring of sage.graphs.graph_generators.GraphGenerators.SylvesterGraph:7: ERROR: Unknown target name: "http://www.win.tue.nl/~aeb/graphs/sylvester.html".

Changed 7 years ago by ncohen

comment:11 Changed 7 years ago by ncohen

Apply trac_14271.patch, trac_14271-review-fc.patch, trac_14271-layouts.patch

comment:12 Changed 7 years ago by ncohen

  • Status changed from needs_work to positive_review

Sorryyyyyyyyy, I just updated it !

Nathann

comment:13 Changed 7 years ago by jdemeyer

  • Work issues documentation deleted

comment:14 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.