Opened 7 years ago

Closed 6 years ago

#14269 closed enhancement (fixed)

Ray class numbers for ideals

Reported by: davidloeffler Owned by: davidloeffler
Priority: major Milestone: sage-5.13
Component: number fields Keywords:
Cc: Merged in: sage-5.13.beta0
Authors: David Loeffler Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

It's easy to wrap Pari's bnrclassno, so let's do it.

apply trac_14269_rebased.patch

Attachments (2)

trac_14269.patch (2.1 KB) - added by davidloeffler 6 years ago.
Now with doctest
trac_14269_rebased.patch (2.3 KB) - added by chapoton 6 years ago.
replaces previous patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by davidloeffler

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 6 years ago by chapoton

you need to doctest every function

Changed 6 years ago by davidloeffler

Now with doctest

comment:4 Changed 6 years ago by davidloeffler

True enough. Here's a version with a doctest.

comment:5 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me. Positive review.

Changed 6 years ago by chapoton

replaces previous patch

comment:6 Changed 6 years ago by chapoton

  • Description modified (diff)

for the patchbots

apply trac_14269_rebased.patch

comment:7 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.12 to sage-5.13

comment:8 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.13.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.