Opened 7 years ago

Closed 7 years ago

#14255 closed enhancement (fixed)

Provides some further functionalities for combinatorial maps

Reported by: stumpc5 Owned by: tbd
Priority: major Milestone: sage-5.9
Component: combinatorics Keywords: combinatorial map
Cc: chrisjamesberg, VivianePons Merged in: sage-5.9.beta1
Authors: Christian Stump Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This patch provides some further functionalities for combinatorial maps.

Attachments (1)

trac_14255-combinatorial_maps-cs.patch (2.4 KB) - added by stumpc5 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by stumpc5

  • Component changed from PLEASE CHANGE to combinatorics
  • Status changed from new to needs_review

comment:2 follow-up: Changed 7 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Hey Christian,

Looks good but there's two minor docstring things. First is I don't understand this line 210 in unbounded_map():

This can then be used to be applied to an element.

Second (and more nitpicky and far less important), the first line is suppose to be in the "affirmative" according to python doc standards:

Return the unbounded..."

Thanks,
Travis

comment:3 in reply to: ↑ 2 Changed 7 years ago by stumpc5

Replying to tscrim:

thanks for your review, Travis!

This can then be used to be applied to an element.

means that this is now an unbounded function and it takes one input parameter, namely self. How do you think I should write that?

Return the unbounded..."

alright, I will do that... (but first waiting for your answer to the above).

comment:4 follow-up: Changed 7 years ago by tscrim

How does this sound:

You can use this method to return a function which takes as input an
element in the domain of the combinatorial map. See the example below.

? Also could you put another blank line between this and the "Return" line? Thank you.

Last edited 7 years ago by tscrim (previous) (diff)

Changed 7 years ago by stumpc5

comment:5 in reply to: ↑ 4 Changed 7 years ago by stumpc5

Replying to tscrim:

How does this sound:

You can use this method to return a function which takes as input an
element in the domain of the combinatorial map. See the example below.

? Also could you put another blank line between this and the "Return" line? Thank you.

Fixed, thanks!

comment:6 Changed 7 years ago by tscrim

  • Status changed from needs_review to positive_review

Thank you Christian.

comment:7 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.