Opened 9 years ago

Closed 9 years ago

Provides some further functionalities for combinatorial maps

Reported by: Owned by: stumpc5 tbd major sage-5.9 combinatorics combinatorial map chrisjamesberg, VivianePons sage-5.9.beta1 Christian Stump Travis Scrimshaw N/A

Description

This patch provides some further functionalities for combinatorial maps.

comment:1 Changed 9 years ago by stumpc5

• Component changed from PLEASE CHANGE to combinatorics
• Status changed from new to needs_review

comment:2 follow-up: ↓ 3 Changed 9 years ago by tscrim

• Reviewers set to Travis Scrimshaw

Hey Christian,

Looks good but there's two minor docstring things. First is I don't understand this line 210 in `unbounded_map()`:

```This can then be used to be applied to an element.
```

Second (and more nitpicky and far less important), the first line is suppose to be in the "affirmative" according to python doc standards:

```Return the unbounded..."
```

Thanks,
Travis

comment:3 in reply to: ↑ 2 Changed 9 years ago by stumpc5

```This can then be used to be applied to an element.
```

means that this is now an unbounded function and it takes one input parameter, namely `self`. How do you think I should write that?

```Return the unbounded..."
```

alright, I will do that... (but first waiting for your answer to the above).

comment:4 follow-up: ↓ 5 Changed 9 years ago by tscrim

How does this sound:

```You can use this method to return a function which takes as input an
element in the domain of the combinatorial map. See the example below.
```

? Also could you put another blank line between this and the "Return" line? Thank you.

Last edited 9 years ago by tscrim (previous) (diff)

comment:5 in reply to: ↑ 4 Changed 9 years ago by stumpc5

How does this sound:

```You can use this method to return a function which takes as input an
element in the domain of the combinatorial map. See the example below.
```

? Also could you put another blank line between this and the "Return" line? Thank you.

Fixed, thanks!

comment:6 Changed 9 years ago by tscrim

• Status changed from needs_review to positive_review

Thank you Christian.

comment:7 Changed 9 years ago by jdemeyer

• Merged in set to sage-5.9.beta1
• Resolution set to fixed
• Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.