Opened 10 years ago

Closed 10 years ago

#14253 closed defect (fixed)

sage.misc.sage_ostools.have_program: use os.access()

Reported by: Jeroen Demeyer Owned by: Jason Grout
Priority: blocker Milestone: sage-5.9
Component: misc Keywords:
Cc: Merged in: sage-5.9.beta0
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

The following is an error I cannot reproduce:

sage -t --long devel/sage/sage/misc/dist.py
**********************************************************************
File "devel/sage/sage/misc/dist.py", line 73, in sage.misc.dist.install_scripts
Failed example:
    install_scripts(str(SAGE_TMP), ignore_existing=True)
Expected:
    Checking that Sage has the command 'gap' installed
    ...
Got:
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    /bin/sh: command: not found
    Checking that Sage has the command 'gap' installed
    The command 'gap' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'gp' installed
    The command 'gp' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'hg' installed
    The command 'hg' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'ipython' installed
    The command 'ipython' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'maxima' installed
    The command 'maxima' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'mwrank' installed
    The command 'mwrank' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'R' installed
    The command 'R' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'singular' installed
    The command 'singular' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'sqlite3' installed
    The command 'sqlite3' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'M2' installed
    The command 'M2' is not available as part of Sage; not creating script.
    <BLANKLINE>
    Checking that Sage has the command 'kash' installed
    The command 'kash' is not available as part of Sage; not creating script.
    <BLANKLINE>
    No scripts created.
**********************************************************************

Attachments (1)

14253_have_program.patch (2.5 KB) - added by Jeroen Demeyer 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: sage.misc.sage_ostools.have_program: use bashsage.misc.sage_ostools.have_program: use os.access()

comment:2 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)

Changed 10 years ago by Jeroen Demeyer

Attachment: 14253_have_program.patch added

comment:3 Changed 10 years ago by Jeroen Demeyer

Status: newneeds_review

comment:4 Changed 10 years ago by David Roe

Reviewers: David Roe
Status: needs_reviewpositive_review

Looks good to me.

comment:5 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.9.beta0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.