Opened 10 years ago

Closed 10 years ago

#14250 closed enhancement (fixed)

GenericGraph.is_circulant() test

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.9
Component: graph theory Keywords:
Cc: Merged in: sage-5.9.beta1
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14251 Stopgaps:

Status badges

Description

Tests whether a graph is a circulant graph (or digraph). Very good to have around when trying to find nice drawings of vertex-transitive graphs :-)

Nathann

Attachments (2)

trac_14250.patch (7.0 KB) - added by ncohen 10 years ago.
trac_14250-review-fc.patch (1.9 KB) - added by chapoton 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by ncohen

Status: newneeds_review

comment:2 Changed 10 years ago by ncohen

Dependencies: #14251

comment:3 Changed 10 years ago by chapoton

Hello,

  • there is a typo in the OUTPUT
    returns ``(False, None`` or
    
  • maybe add a link to the wikipedia article :wikipedia:Circulant graph ?

Changed 10 years ago by ncohen

Attachment: trac_14250.patch added

comment:4 Changed 10 years ago by ncohen

Done !

Nathann

Changed 10 years ago by chapoton

Attachment: trac_14250-review-fc.patch added

comment:5 Changed 10 years ago by chapoton

Hello,

once the bot turns green again, and if you are happy with my review patch, you can set a positive review,

cheers,

Frederic

comment:6 Changed 10 years ago by ncohen

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

Green light from the bot, and thaaaaaaaaank you for your modifications. Looks like I still sound like a foreigner when I talk about groups :-)

Nathann

comment:7 Changed 10 years ago by jdemeyer

Merged in: sage-5.9.beta1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.