Patch to FLINT fails to apply because of double path separator // in filenames

[tkluck]

The flint spkg fails in the patch phase on FreeBSD, because the patch file for longlong.h uses // as a path separator instead of /. This is very easy to fix.

---

New spkg: ​http://www.infty.nl/misc/flint-1.5.2.p3.spkg

[leif]

ROFL.

Please don't attach binary files to tickets, but instead provide links to them...

[leif]

Replying to leif:

Please don't attach binary files to tickets, but instead provide links to them...

There's even ​https://code.google.com/p/spkg-upload/ btw. for that reason... ;-)

[tkluck]

Here's a link: ​http://www.infty.nl/misc/flint-1.5.2.p3.spkg

Off topic: this goes to show how badly the packaging system needs an overhaul. There shouldn't be any need to upload a binary file for this, since it's just a text patch to the package metadata. Fortunately, people are working on that... :-)

[leif]

Replying to tkluck:

Here's a link: ​http://www.infty.nl/misc/flint-1.5.2.p3.spkg

Thanks, I'll then delete the attached one. (You can still attach a diff for reference / review.)

Off topic: this goes to show how badly the packaging system needs an overhaul. There shouldn't be any need to upload a binary file for this, since it's just a text patch to the package metadata. Fortunately, people are working on that... :-)

Yes. At the very least, we should split off the (hopefully) vanilla src/ tree from Sage's part.

(Even worse, Jeroen's merger script currently keeps modifying some "unchanged", already released spkgs from beta to beta. The differences are subtle changes in the metadata due to needless repackaging, but of course mtimes and md5sums differ afterwards. But you have to download and unpack them to check/see this...)

[leif]

Ooops, just noticed ​http://www.infty.nl/misc/flint-1.5.2.p3.spkg is a plain tar file.

[leif]

Spkg looks ok, except that the changelog entry (and the commit message) should contain the ticket number (#14241).

I'd also use (bzip2) compression, although it'll (currently) get repackaged upon merging, as mentioned above.

[tkluck]

I uploaded a new version (md5sum 74149705ef0a7972c3573c62921204ae) including the trac number. It's not a plain tar file and I don't think it was? It's gzipped though, not bzip (just tar -czf).

I also added the exported tip as an attachment for your reviewing pleasure.

[leif]

Ok.

FWIW, as the filenames do not start with //, I think FreeBSD's patch is broken here, but never mind.

[tkluck]

Replying to leif:

FWIW, as the filenames do not start with //, I think FreeBSD's patch is broken here, but never mind.

Yeah, I agree. This is the first time I use bsd, too, and I'm having a hard time adjusting in general. I guess portability is good, though.

Thanks for reviewing!