Opened 7 years ago

Closed 7 years ago

#14241 closed defect (fixed)

Patch to FLINT fails to apply because of double path separator // in filenames

Reported by: tkluck Owned by: tbd
Priority: trivial Milestone: sage-5.9
Component: packages: standard Keywords: spkg FreeBSD
Cc: Merged in: sage-5.9.beta0
Authors: Timo Kluck Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by leif)

The flint spkg fails in the patch phase on FreeBSD, because the patch file for longlong.h uses // as a path separator instead of /. This is very easy to fix.


New spkg: http://www.infty.nl/misc/flint-1.5.2.p3.spkg

Attachments (1)

trac_14241_path_separator_flint.patch (1.3 KB) - added by tkluck 7 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 follow-up: Changed 7 years ago by leif

ROFL.


Please don't attach binary files to tickets, but instead provide links to them...

comment:2 in reply to: ↑ 1 Changed 7 years ago by leif

Replying to leif:

Please don't attach binary files to tickets, but instead provide links to them...

There's even https://code.google.com/p/spkg-upload/ btw. for that reason... ;-)

comment:3 Changed 7 years ago by tkluck

Here's a link: http://www.infty.nl/misc/flint-1.5.2.p3.spkg

Off topic: this goes to show how badly the packaging system needs an overhaul. There shouldn't be any need to upload a binary file for this, since it's just a text patch to the package metadata. Fortunately, people are working on that... :-)

comment:4 Changed 7 years ago by tkluck

  • Status changed from new to needs_review

comment:5 Changed 7 years ago by leif

Replying to tkluck:

Here's a link: http://www.infty.nl/misc/flint-1.5.2.p3.spkg

Thanks, I'll then delete the attached one. (You can still attach a diff for reference / review.)


Off topic: this goes to show how badly the packaging system needs an overhaul. There shouldn't be any need to upload a binary file for this, since it's just a text patch to the package metadata. Fortunately, people are working on that... :-)

Yes. At the very least, we should split off the (hopefully) vanilla src/ tree from Sage's part.

(Even worse, Jeroen's merger script currently keeps modifying some "unchanged", already released spkgs from beta to beta. The differences are subtle changes in the metadata due to needless repackaging, but of course mtimes and md5sums differ afterwards. But you have to download and unpack them to check/see this...)

comment:6 Changed 7 years ago by leif

  • Description modified (diff)

comment:7 Changed 7 years ago by leif

  • Keywords spkg added

comment:8 Changed 7 years ago by leif

Ooops, just noticed http://www.infty.nl/misc/flint-1.5.2.p3.spkg is a plain tar file.

comment:9 Changed 7 years ago by leif

  • Reviewers set to Leif Leonhardy

Spkg looks ok, except that the changelog entry (and the commit message) should contain the ticket number (#14241).

I'd also use (bzip2) compression, although it'll (currently) get repackaged upon merging, as mentioned above.

comment:10 Changed 7 years ago by tkluck

I uploaded a new version (md5sum 74149705ef0a7972c3573c62921204ae) including the trac number. It's not a plain tar file and I don't think it was? It's gzipped though, not bzip (just tar -czf).

I also added the exported tip as an attachment for your reviewing pleasure.

Changed 7 years ago by tkluck

comment:11 follow-up: Changed 7 years ago by leif

  • Keywords FreeBSD added
  • Status changed from needs_review to positive_review
  • Summary changed from flint fails to patch because of double path separator // in patch to Patch to FLINT fails to apply because of double path separator // in filenames

Ok.

FWIW, as the filenames do not start with //, I think FreeBSD's patch is broken here, but never mind.

comment:12 Changed 7 years ago by leif

  • Milestone changed from sage-5.9 to sage-5.8
  • Priority changed from major to trivial

comment:13 in reply to: ↑ 11 Changed 7 years ago by tkluck

Replying to leif:

FWIW, as the filenames do not start with //, I think FreeBSD's patch is broken here, but never mind.

Yeah, I agree. This is the first time I use bsd, too, and I'm having a hard time adjusting in general. I guess portability is good, though.

Thanks for reviewing!

comment:14 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.8 to sage-5.9

comment:15 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.