Opened 8 years ago

Closed 8 years ago

#14233 closed enhancement (fixed)

small cleanup of sage/homology

Reported by: chapoton Owned by: tbd
Priority: minor Milestone: sage-5.8
Component: algebraic topology Keywords: simplicial
Cc: ncohen Merged in: sage-5.8.beta4
Authors: Frédéric Chapoton Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This ticket

  • removes unnecessary imports
  • remove unused variables

in a few files in sage/homology

and moreover corrects an error in MooreSpace?.

Attachments (1)

trac-14233-cleanup_of_homology-fc.patch​ (4.5 KB) - added by chapoton 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by chapoton

comment:1 Changed 8 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Cc ncohen added
  • Component changed from PLEASE CHANGE to algebraic topology
  • Keywords simplicial added
  • Priority changed from major to minor
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 8 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.8 to sage-5.9

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.9 to sage-5.8

comment:5 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.8.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.