Changes between Initial Version and Version 3 of Ticket #14225


Ignore:
Timestamp:
Mar 5, 2013, 10:35:54 AM (10 years ago)
Author:
SimonKing
Comment:

I think it is better to keep separate topics on separate tickets. Hence, I only remove __classcall_private__ here, but do not cache stuff.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14225

    • Property Status changed from new to needs_review
  • Ticket #14225 – Description

    initial v3  
    44
    55However, I doubt that a `__classcall_private__` method makes sense that simply puts a `Integer(k)` around an argument `k` that is supposed to be an integer (python int or whatever). Since caching is by equality and since k as int, Integer, NN, QQ etc. evaluates equal, caching is not an issue here.
    6 
    7 In addition to that, in my patch I suggest to cache a couple of data in a cached_method. This is because these data inherit from `UniqueRepresentation` and hence are only weakly cached, so that it makes sense to cache them in a partition, if this partition will need the data repeatedly.