Opened 10 years ago
Closed 10 years ago
#14216 closed enhancement (fixed)
clean-up of parts of combinat
| Reported by: | Frédéric Chapoton | Owned by: | Sage Combinat CC user |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-5.8 |
| Component: | combinatorics | Keywords: | clean-up |
| Cc: | Sage Combinat CC user | Merged in: | sage-5.8.beta3 |
| Authors: | Frédéric Chapoton | Reviewers: | Nathann Cohen |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
Here is a small patch that
- removes duplicate or unused imports
- changes the raise syntax to Python 3 syntax
- removes unused variables
in a few combinat files
Attachments (1)
Change History (5)
Changed 10 years ago by
| Attachment: | trac-14216-combinat-small-cleanup-fc.patch added |
|---|
comment:1 Changed 10 years ago by
| Authors: | → Frédéric Chapoton |
|---|---|
| Status: | new → needs_review |
comment:2 Changed 10 years ago by
| Status: | needs_review → positive_review |
|---|
comment:3 Changed 10 years ago by
| Reviewers: | → Nathann Cohen |
|---|
comment:4 Changed 10 years ago by
| Merged in: | → sage-5.8.beta3 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Makes sense, passes tests, good to go ! The only problem with this ticket is that it should be named "clean up parts of combinat 1/3457", because there is that much left to do
:-PCc me if you write any other such ticket !
Nathann