Opened 8 years ago

Closed 8 years ago

#14216 closed enhancement (fixed)

clean-up of parts of combinat

Reported by: chapoton Owned by: sage-combinat
Priority: minor Milestone: sage-5.8
Component: combinatorics Keywords: clean-up
Cc: sage-combinat Merged in: sage-5.8.beta3
Authors: Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Here is a small patch that

  • removes duplicate or unused imports
  • changes the raise syntax to Python 3 syntax
  • removes unused variables

in a few combinat files

Attachments (1)

trac-14216-combinat-small-cleanup-fc.patch​ (4.1 KB) - added by chapoton 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by chapoton

comment:1 Changed 8 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by ncohen

  • Status changed from needs_review to positive_review

Makes sense, passes tests, good to go ! The only problem with this ticket is that it should be named "clean up parts of combinat 1/3457", because there is that much left to do :-P

Cc me if you write any other such ticket !

Nathann

comment:3 Changed 8 years ago by ncohen

  • Reviewers set to Nathann Cohen

comment:4 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.8.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.