Opened 10 years ago

Closed 10 years ago

#14216 closed enhancement (fixed)

clean-up of parts of combinat

Reported by: Frédéric Chapoton Owned by: Sage Combinat CC user
Priority: minor Milestone: sage-5.8
Component: combinatorics Keywords: clean-up
Cc: Sage Combinat CC user Merged in: sage-5.8.beta3
Authors: Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges


Here is a small patch that

  • removes duplicate or unused imports
  • changes the raise syntax to Python 3 syntax
  • removes unused variables

in a few combinat files

Attachments (1)

trac-14216-combinat-small-cleanup-fc.patch (4.1 KB) - added by Frédéric Chapoton 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Frédéric Chapoton

comment:1 Changed 10 years ago by Frédéric Chapoton

Authors: Frédéric Chapoton
Status: newneeds_review

comment:2 Changed 10 years ago by Nathann Cohen

Status: needs_reviewpositive_review

Makes sense, passes tests, good to go ! The only problem with this ticket is that it should be named "clean up parts of combinat 1/3457", because there is that much left to do :-P

Cc me if you write any other such ticket !


comment:3 Changed 10 years ago by Nathann Cohen

Reviewers: Nathann Cohen

comment:4 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.8.beta3
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.